Skip to content

Commit cb98925

Browse files
committed
[rb] Enable Edge tests on RBE
1 parent e9bbb29 commit cb98925

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,8 @@ def chrome_options(args: [], **opts)
251251
def edge_options(args: [], **opts)
252252
opts[:binary] ||= ENV['EDGE_BINARY'] if ENV.key?('EDGE_BINARY')
253253
args << '--headless=chrome' if ENV['HEADLESS']
254+
args << '--no-sandbox'
255+
args << '--disable-gpu'
254256
WebDriver::Options.edge(browser_version: 'stable', args: args, **opts)
255257
end
256258

rb/spec/tests.bzl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,16 @@ BROWSERS = {
3535
"edge": {
3636
"data": edge_data,
3737
"deps": ["//rb/lib/selenium/webdriver:edge"],
38-
"tags": [
39-
"skip-remote", # TODO: Add Linux version of Edge to pinned browsers.
40-
],
38+
"tags": [],
4139
"target_compatible_with": [],
4240
"env": {
4341
"WD_REMOTE_BROWSER": "edge",
4442
"WD_SPEC_DRIVER": "edge",
4543
} | select({
44+
"@selenium//common:use_pinned_linux_edge": {
45+
"EDGE_BINARY": "$(location @linux_edge//:opt/microsoft/msedge/microsoft-edge)",
46+
"MSEDGEDRIVER_BINARY": "$(location @linux_edgedriver//:msedgedriver)",
47+
},
4648
"@selenium//common:use_pinned_macos_edge": {
4749
"EDGE_BINARY": "$(location @mac_edge//:Edge.app)/Contents/MacOS/Microsoft\\ Edge",
4850
"MSEDGEDRIVER_BINARY": "$(location @mac_edgedriver//:msedgedriver)",

0 commit comments

Comments
 (0)