[docker] Fix existing docker functionality

Author: shs96c

java/client/src/org/openqa/selenium/remote/http/HttpResponse.java

@@ -26,6 +26,10 @@ public class HttpResponse extends HttpMessage<HttpResponse> {
 
   private int status = HTTP_OK;
 
+  public boolean isSuccessful() {
+    return getStatus() >= HTTP_OK && getStatus() < 300;
+  }
+
   public int getStatus() {
     return status;
   }

java/server/src/org/openqa/selenium/docker/BUILD.bazel

@@ -3,6 +3,7 @@ java_library(
     srcs = glob(["*.java"]),
     visibility = [
         "//java/server/src/org/openqa/selenium/grid/docker:__pkg__",
+        "//java/server/test/org/openqa/selenium:__subpackages__",
     ],
     deps = [
         "//java/client/src/org/openqa/selenium/json",

java/server/src/org/openqa/selenium/docker/Container.java

@@ -50,7 +50,7 @@ public ContainerId getId() {
   public void start() {
     LOG.info("Starting " + getId());
     HttpResponse res = client.execute(new HttpRequest(POST, String.format("/containers/%s/start", id)));
-    if (res.getStatus() != HTTP_OK) {
+    if (!res.isSuccessful()) {
       throw new WebDriverException("Unable to start container: " + Contents.string(res));
     }
   }
@@ -66,7 +66,7 @@ public void stop(Duration timeout) {
       .addQueryParameter("t", seconds);
 
     HttpResponse res = client.execute(request);
-    if (res.getStatus() != HTTP_OK) {
+    if (!res.isSuccessful()) {
       throw new WebDriverException("Unable to stop container: " + Contents.string(res));
     }
   }

java/server/src/org/openqa/selenium/grid/commands/Standalone.java

@@ -59,7 +59,7 @@
 @AutoService(CliCommand.class)
 public class Standalone implements CliCommand {
 
-  public static final Logger LOG = Logger.getLogger("selenium");
+  private static final Logger LOG = Logger.getLogger("selenium");
 
   @Override
   public String getName() {

java/server/test/org/openqa/selenium/docker/BUILD.bazel

@@ -0,0 +1,17 @@
+
+
+load("//java:defs.bzl", "java_test_suite")
+
+java_test_suite(
+    name = "MediumTests",
+    size = "medium",
+    srcs = glob(["*.java"]),
+    tags = [
+        "manual",
+    ],
+    deps = [
+      "//java/client/src/org/openqa/selenium/remote",
+      "//java/server/src/org/openqa/selenium/docker",
+      "//third_party/java/junit",
+    ],
+)