Skip to content

Commit e33ed59

Browse files
committed
Remove unused constants
1 parent f052b7b commit e33ed59

File tree

4 files changed

+1
-31
lines changed

4 files changed

+1
-31
lines changed

java/server/src/org/openqa/selenium/grid/sessionqueue/NewSessionQueue.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import org.openqa.selenium.grid.data.RequestId;
2121
import org.openqa.selenium.internal.Require;
22-
import org.openqa.selenium.remote.http.HttpRequest;
2322
import org.openqa.selenium.remote.tracing.Tracer;
2423
import org.openqa.selenium.status.HasReadyState;
2524

@@ -30,8 +29,6 @@
3029

3130
public abstract class NewSessionQueue implements HasReadyState {
3231

33-
public static final String SESSIONREQUEST_TIMESTAMP_HEADER = "new-session-request-timestamp";
34-
public static final String SESSIONREQUEST_ID_HEADER = "request-id";
3532
protected final Tracer tracer;
3633
protected final Duration retryInterval;
3734
protected final Duration requestTimeout;
@@ -54,12 +51,6 @@ protected NewSessionQueue(Tracer tracer, Duration retryInterval, Duration reques
5451

5552
public abstract List<Object> getQueuedRequests();
5653

57-
public void addRequestHeaders(HttpRequest request, RequestId reqId) {
58-
long timestamp = Instant.now().getEpochSecond();
59-
request.addHeader(SESSIONREQUEST_TIMESTAMP_HEADER, Long.toString(timestamp));
60-
request.addHeader(SESSIONREQUEST_ID_HEADER, reqId.toString());
61-
}
62-
6354
public boolean hasRequestTimedOut(SessionRequest request) {
6455
Instant enque = request.getEnqueued();
6556
Instant deque = Instant.now();

java/server/src/org/openqa/selenium/grid/sessionqueue/RemoveFromSessionQueue.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,7 @@ public HttpResponse execute(HttpRequest req) {
5454
HttpResponse response = new HttpResponse();
5555

5656
if (sessionRequest.isPresent()) {
57-
SessionRequest request = sessionRequest.get();
58-
59-
return response
60-
.setHeader(
61-
NewSessionQueue.SESSIONREQUEST_TIMESTAMP_HEADER,
62-
String.valueOf(request.getEnqueued().getEpochSecond()))
63-
.setContent(Contents.asJson(sessionRequest));
57+
return response.setContent(Contents.asJson(sessionRequest));
6458
} else {
6559
response.setStatus(HTTP_NO_CONTENT);
6660
}

java/server/src/org/openqa/selenium/grid/sessionqueue/remote/RemoteNewSessionQueuer.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,12 @@
4444
import java.util.List;
4545
import java.util.Optional;
4646

47-
import static org.openqa.selenium.grid.sessionqueue.NewSessionQueue.SESSIONREQUEST_ID_HEADER;
48-
import static org.openqa.selenium.grid.sessionqueue.NewSessionQueue.SESSIONREQUEST_TIMESTAMP_HEADER;
4947
import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
5048
import static org.openqa.selenium.remote.http.HttpMethod.GET;
5149
import static org.openqa.selenium.remote.http.HttpMethod.POST;
5250

5351
public class RemoteNewSessionQueuer extends NewSessionQueuer {
5452

55-
private static final String timestampHeader = SESSIONREQUEST_TIMESTAMP_HEADER;
56-
private static final String reqIdHeader = SESSIONREQUEST_ID_HEADER;
5753
private static final Json JSON = new Json();
5854
private final HttpClient client;
5955
private final Filter addSecret;
@@ -100,8 +96,6 @@ public boolean retryAddToQueue(SessionRequest request) {
10096
new HttpRequest(POST, "/se/grid/newsessionqueuer/session/retry/" + request.getRequestId());
10197
HttpTracing.inject(tracer, tracer.getCurrentContext(), upstream);
10298
upstream.setContent(Contents.asJson(request));
103-
upstream.setHeader(timestampHeader, String.valueOf(request.getEnqueued().getEpochSecond()));
104-
upstream.setHeader(reqIdHeader, request.getRequestId().toString());
10599
HttpResponse response = client.with(addSecret).execute(upstream);
106100
return Values.get(response, Boolean.class);
107101
}

java/server/test/org/openqa/selenium/grid/sessionqueue/local/LocalNewSessionQueueTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,11 @@
2626
import org.openqa.selenium.grid.data.NewSessionRejectedEvent;
2727
import org.openqa.selenium.grid.data.NewSessionRequestEvent;
2828
import org.openqa.selenium.grid.data.RequestId;
29-
import org.openqa.selenium.grid.data.Session;
3029
import org.openqa.selenium.grid.sessionqueue.NewSessionQueue;
3130
import org.openqa.selenium.grid.sessionqueue.SessionRequest;
32-
import org.openqa.selenium.remote.NewSessionPayload;
33-
import org.openqa.selenium.remote.http.HttpMethod;
34-
import org.openqa.selenium.remote.http.HttpRequest;
3531
import org.openqa.selenium.remote.tracing.DefaultTestTracer;
3632
import org.openqa.selenium.remote.tracing.Tracer;
3733

38-
import java.io.IOException;
39-
import java.io.UncheckedIOException;
4034
import java.time.Duration;
4135
import java.time.Instant;
4236
import java.util.List;
@@ -51,10 +45,7 @@
5145
import static org.junit.Assert.assertEquals;
5246
import static org.junit.Assert.assertFalse;
5347
import static org.junit.Assert.assertTrue;
54-
import static org.openqa.selenium.grid.sessionqueue.NewSessionQueue.SESSIONREQUEST_TIMESTAMP_HEADER;
5548
import static org.openqa.selenium.remote.Dialect.W3C;
56-
import static org.openqa.selenium.remote.http.Contents.utf8String;
57-
import static org.openqa.selenium.remote.http.HttpMethod.POST;
5849

5950
public class LocalNewSessionQueueTest {
6051

0 commit comments

Comments
 (0)