Skip to content

Commit e3a896b

Browse files
JohanLorenzojleyba
authored andcommitted
[js] Marionette support: Remove dev edition enforcement (#2135)
1 parent 1019ef2 commit e3a896b

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

javascript/node/selenium-webdriver/CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* Added new wait conditions: `until.urlIs()`, `until.urlContains()`,
66
`until.urlMatches()`
77
* Added work around for [GeckoDriver bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1274924) raising a type conversion error
8+
* Removed the mandatory use of Firefox Dev Edition, when using Marionette driver
89

910
## v2.53.2
1011

javascript/node/selenium-webdriver/firefox/index.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -275,14 +275,8 @@ function findGeckoDriver() {
275275
* @return {!remote.DriverService} .
276276
*/
277277
function createGeckoDriverService(binary) {
278-
// Firefox's Developer Edition is currently required for Marionette.
279-
let exe;
280-
if (typeof binary === 'string') {
281-
exe = Promise.resolve(binary);
282-
} else {
283-
binary.useDevEdition();
284-
exe = binary.locate();
285-
}
278+
let exe = typeof binary === 'string' ?
279+
Promise.resolve(binary) : binary.locate();
286280

287281
let geckoDriver = findGeckoDriver();
288282
let port = portprober.findFreePort();

0 commit comments

Comments
 (0)