Skip to content

Commit eaddcc7

Browse files
committed
Updating PR template, and removing references to CLA [skip ci]
1 parent df6be2e commit eaddcc7

File tree

3 files changed

+31
-17
lines changed

3 files changed

+31
-17
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,33 @@ Please be aware that the Selenium Grid 3.x is being deprecated in favour of the
33
upcoming version 4.x. We won't be receiving any PRs related to the Grid 3.x code. Thanks!
44
-->
55

6+
**Thanks for contributing to Selenium!**
7+
**A PR well described will help maintainers to quickly review and merge it**
68

9+
Before submitting your PR, please check our [contributing](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md) guidelines.
10+
Avoid large PRs, help reviewers by making them as simple and short as possible.
711

812

9-
- [ ] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)
13+
<!--- Provide a general summary of your changes in the Title above -->
14+
15+
### Description
16+
<!--- Describe your changes in detail -->
17+
18+
### Motivation and Context
19+
<!--- Why is this change required? What problem does it solve? -->
20+
21+
### Types of changes
22+
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
23+
- [ ] Bug fix (non-breaking change which fixes an issue)
24+
- [ ] New feature (non-breaking change which adds functionality)
25+
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
26+
27+
### Checklist
28+
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
29+
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
30+
- [ ] I have read the [contributing](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md) document.
31+
- [ ] My change requires a change to the documentation.
32+
- [ ] I have updated the documentation accordingly.
33+
- [ ] I have added tests to cover my changes.
34+
- [ ] All new and existing tests passed.
35+
<!--- Provide a general summary of your changes in the Title above -->

CONTRIBUTING.md

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -182,18 +182,7 @@ Use `git rebase` (not `git merge`) to sync your work from time to time.
182182
Bug fixes and features **should have tests**. Look at other tests to
183183
see how they should be structured.
184184

185-
### Step 6: Sign the CLA
186-
187-
Before we can accept, we first ask people to sign a
188-
[Contributor License Agreement](https://spreadsheets.google.com/spreadsheet/viewform?hl=en_US&formkey=dFFjXzBzM1VwekFlOWFWMjFFRjJMRFE6MQ#gid=0)
189-
(or CLA). We ask this so that we know that contributors have the right
190-
to donate the code.
191-
192-
When you open your pull request we ask that you indicate that you've
193-
signed the CLA. This will reduce the time it takes for us to integrate
194-
it.
195-
196-
### Step 7: Push
185+
### Step 8: Push
197186

198187
```shell
199188
% git push origin my-feature-branch
@@ -208,7 +197,7 @@ comments to address, apply your changes in new commits (preferably
208197
[fixups](http://git-scm.com/docs/git-commit)) and push to the same
209198
branch.
210199

211-
### Step 8: Integration
200+
### Step 9: Integration
212201

213202
When code review is complete, a committer will take your PR and
214203
integrate it on Selenium's master branch. Because we like to keep a
@@ -250,3 +239,4 @@ Issues are labelled to make them easier to categorise and find by:
250239
Selenium contributors frequent the `#selenium` channel on
251240
[`irc.freenode.org`](https://webchat.freenode.net/). You can also join
252241
the [`selenium-developers@` mailing list](https://groups.google.com/forum/#!forum/selenium-developers).
242+
Check https://selenium.dev/support/ for a complete list of options to communicate.

javascript/node/selenium-webdriver/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ Additional resources include
122122
## Contributing
123123

124124
Contributions are accepted either through [GitHub][gh] pull requests or patches
125-
via the [Selenium issue tracker][issues]. You must sign our
126-
[Contributor License Agreement][cla] before your changes will be accepted.
125+
via the [Selenium issue tracker][issues].
127126

128127
## Node Support Policy
129128

@@ -217,7 +216,6 @@ under the License.
217216
[LTS]: https://github.com/nodejs/LTS
218217
[PATH]: http://en.wikipedia.org/wiki/PATH_%28variable%29
219218
[api]: http://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/
220-
[cla]: http://goo.gl/qC50R
221219
[chrome]: http://chromedriver.storage.googleapis.com/index.html
222220
[gh]: https://github.com/SeleniumHQ/selenium/
223221
[issues]: https://github.com/SeleniumHQ/selenium/issues

0 commit comments

Comments
 (0)