[JS] Use to create absolute path for browser binary fixes #12479

harsha509 · harsha509 · commit ec2f0fb15625 · 2023-08-12T14:15:55.000+05:30
diff --git a/javascript/node/selenium-webdriver/common/seleniumManager.js b/javascript/node/selenium-webdriver/common/seleniumManager.js
@@ -78,7 +78,7 @@ function driverLocation(options) {
     options.get('ms:edgeOptions') ||
     options.get('moz:firefoxOptions')
   if (vendorOptions && vendorOptions.binary && vendorOptions.binary !== '') {
-    args.push('--browser-path', '"' + vendorOptions.binary + '"')
+    args.push('--browser-path', path.resolve(vendorOptions.binary))
   }
 
   const proxyOptions = options.getProxy();

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ function driverLocation(options) {`
`78`	`78`	`options.get('ms:edgeOptions') \|\|`
`79`	`79`	`options.get('moz:firefoxOptions')`
`80`	`80`	`if (vendorOptions && vendorOptions.binary && vendorOptions.binary !== '') {`
`81`		`- args.push('--browser-path', '"' + vendorOptions.binary + '"')`
	`81`	`+ args.push('--browser-path', path.resolve(vendorOptions.binary))`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`const proxyOptions = options.getProxy();`