Skip to content

Commit eec4236

Browse files
committed
[rb] update guards to get tests passing
1 parent 1cd84f7 commit eec4236

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

rb/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ DEPENDENCIES
9898
yard (~> 0.9.11)
9999

100100
BUNDLED WITH
101-
2.2.33
101+
2.2.34

rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,22 @@ class BiDi
3737
expect(browsing_context.id).not_to be_nil
3838
end
3939

40-
it 'can create a window with a reference context', except: {browser: %i[chrome edge]} do
40+
it 'can create a window with a reference context', except: [{browser: :chrome,
41+
platform: %i[linux macosx]},
42+
{browser: :edge}] do
4143
browsing_context = described_class.new(driver: driver, type: :window,
4244
reference_context: driver.window_handle)
4345
expect(browsing_context.id).not_to be_nil
4446
end
4547

46-
it 'can create a tab' do
48+
it 'can create a tab without a reference context' do
4749
browsing_context = described_class.new(driver: driver, type: :tab)
4850
expect(browsing_context.id).not_to be_nil
4951
end
5052

51-
it 'can create a tab with a reference context', except: {browser: %i[chrome edge]} do
53+
it 'can create a tab with a reference context', except: [{browser: :chrome,
54+
platform: %i[linux macosx]},
55+
{browser: :edge}] do
5256
browsing_context = described_class.new(driver: driver, type: :tab, reference_context: driver.window_handle)
5357
expect(browsing_context.id).not_to be_nil
5458
end

rb/spec/integration/selenium/webdriver/manager_spec.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,6 @@ module WebDriver
8181
expect(driver.manage.cookie_named('domain')[:domain]).to eq('.saucelabs.com')
8282
end
8383

84-
it 'does not allow domain to be set for localhost', except: {browser: %i[safari safari_preview]} do
85-
expect {
86-
driver.manage.add_cookie name: 'domain',
87-
value: 'localhost',
88-
domain: 'localhost'
89-
}.to raise_error(Error::UnableToSetCookieError)
90-
end
91-
9284
it 'does not allow setting on a different domain', except: {browser: %i[safari safari_preview]} do
9385
expect {
9486
driver.manage.add_cookie name: 'domain',

0 commit comments

Comments
 (0)