Skip to content

Commit f56924e

Browse files
committed
Generate BuildInfo for JARs we generate
This is not an ideal solution, but it's good enough for now.
1 parent 4444c7f commit f56924e

File tree

3 files changed

+28
-2
lines changed

3 files changed

+28
-2
lines changed

java/client/src/org/openqa/selenium/internal/BuildInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ public String getReleaseLabel() {
8484

8585
/** @return The embedded build revision or "unknown". */
8686
public String getBuildRevision() {
87-
return BUILD_PROPERTIES.getProperty("Selenium-Revision", "unknown");
87+
return BUILD_PROPERTIES.getProperty("Build-Revision", "unknown");
8888
}
8989

9090
/** @return The embedded build time or "unknown". */
9191
public String getBuildTime() {
92-
return BUILD_PROPERTIES.getProperty("Selenium-Build-Time", "unknown");
92+
return BUILD_PROPERTIES.getProperty("Build-Time", "unknown");
9393
}
9494

9595
@Override

java/server/src/org/openqa/grid/selenium/BUCK

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,25 @@
1+
include_defs('//SELENIUM_VERSION')
2+
3+
# Force a rebuild every time we're parsed.
4+
15
java_binary(name = 'selenium',
26
main_class = 'org.openqa.grid.selenium.GridLauncherV3',
7+
manifest_file = ':manifest',
8+
merge_manifests = True,
39
deps = [
410
':classes',
511
],
612
)
713

14+
genrule(name = 'manifest',
15+
out = 'build-info.mf',
16+
cmd = "$(exe :generate-build-info) %s > $OUT" % (SE_VERSION),
17+
)
18+
19+
python_binary(name = 'generate-build-info',
20+
main = 'generate-build-info.py',
21+
)
22+
823
java_library(name = 'classes',
924
srcs = glob(['**/*.java']),
1025
deps = [
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import sys
2+
3+
4+
def main(argv):
5+
print """
6+
Name: Build-Info
7+
Selenium-Version: %s
8+
""" % (argv[1])
9+
10+
11+
sys.exit(main(sys.argv))

0 commit comments

Comments
 (0)