ci: improve travis integration conditionals #2523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration conditionals were wrong for the spread tests as they require Google Keys which not many people have setup before hand leading to many failed runs when pushing to branches not owned by snapcore/snapcraft. Also remove the unnecessary cron conditional, as it is no longer used. Additionally, indent the integration scripts so they match all other declarations in .travis.yml Signed-off-by: Sergio Schvezov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
=========================================
Coverage ? 89.17%
=========================================
Files ? 201
Lines ? 13615
Branches ? 2057
=========================================
Hits ? 12141
Misses ? 1039
Partials ? 435Continue to review full report at Codecov.
|
cmatsuoka
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration conditionals were wrong for the spread tests as they
require Google Keys which not many people have setup before hand leading
to many failed runs when pushing to branches not owned by
snapcore/snapcraft.
Also remove the unnecessary cron conditional, as it is no longer used.
Additionally, indent the integration scripts so they match all other
declarations in .travis.yml
Signed-off-by: Sergio Schvezov [email protected]
./runtests.sh static?./runtests.sh tests/unit?