Skip to content

Port StarIsType fix to GHC 7 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

andreasabel
Copy link
Contributor

Continues this PR (I cannot push to it):

@andreasabel andreasabel changed the base branch from staristype to master December 7, 2022 17:20
@andreasabel
Copy link
Contributor Author

Dunno why CI does not run here. I tested this locally with GHC 7.10 and 9.4.

@stevenfontanella
Copy link
Owner

Thanks Andreas! I see that it works on GHC 9.4. I can't seem to install GHC 7 on my machine (I get a seg fault), but your fix looks correct. Let me try the CI too.

@andreasabel
Copy link
Contributor Author

That CI does not run here seems to be a bug in GitHub. Since I continued your branch in my branch, when I opened the PR it was not opened against master but your branch. CI is set up to run only on PRs against master, to prevent duplicate CI runs. I then changed the PR base to master, but this did not trigger a CI run.

Let me try the CI too.

@stevenfontanella stevenfontanella merged commit 5875b2f into stevenfontanella:master Dec 9, 2022
@stevenfontanella
Copy link
Owner

Will create a patch release with this and #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants