Fixed(NotificationAPI): Fix termux-notification actions not updating or conflicting between notifications due to same request code being used for the PendingIntent of all actions and also specify PendingIntent.FLAG_IMMUTABLE to prevent any modification

- https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

Closes #677, Closes #764

Author: agnostic-apollo

app/src/main/java/com/termux/api/apis/NotificationAPI.java

@@ -22,6 +22,8 @@
 import com.termux.api.R;
 import com.termux.api.TermuxAPIConstants;
 import com.termux.api.TermuxApiReceiver;
+import com.termux.api.util.PendingIntentUtils;
+import com.termux.api.util.PluginUtils;
 import com.termux.api.util.ResultReturner;
 import com.termux.shared.logger.Logger;
 import com.termux.shared.shell.command.ExecutionCommand;
@@ -421,6 +423,10 @@ static Intent createExecuteIntent(String action){
 
     static PendingIntent createAction(final Context context, String action){
         Intent executeIntent = createExecuteIntent(action);
-        return PendingIntent.getService(context, 0, executeIntent, 0);
+        // Use unique request code for each action created so that pending intent extras are updated
+        // and do not conflict when same action is recreated or between actions of different notifications.
+        return PendingIntent.getService(context,
+                PluginUtils.getLastPendingIntentRequestCode(context), executeIntent,
+                PendingIntentUtils.getPendingIntentImmutableFlag());
     }
 }

app/src/main/java/com/termux/api/util/PendingIntentUtils.java

@@ -0,0 +1,34 @@
+package com.termux.api.util;
+
+import android.app.PendingIntent;
+import android.os.Build;
+
+public class PendingIntentUtils {
+
+    /**
+     * Get {@link PendingIntent#FLAG_IMMUTABLE} flag.
+     *
+     * - https://developer.android.com/guide/components/intents-filters#DeclareMutabilityPendingIntent
+     * - https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
+     */
+    public static int getPendingIntentImmutableFlag() {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M)
+            return PendingIntent.FLAG_IMMUTABLE;
+        else
+            return 0;
+    }
+
+    /**
+     * Get {@link PendingIntent#FLAG_MUTABLE} flag.
+     *
+     * - https://developer.android.com/guide/components/intents-filters#DeclareMutabilityPendingIntent
+     * - https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
+     */
+    public static int getPendingIntentMutableFlag() {
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S)
+            return PendingIntent.FLAG_MUTABLE;
+        else
+            return 0;
+    }
+
+}

app/src/main/java/com/termux/api/util/PluginUtils.java

@@ -0,0 +1,36 @@
+package com.termux.api.util;
+
+import android.app.PendingIntent;
+import android.content.Context;
+
+import com.termux.shared.termux.settings.preferences.TermuxPreferenceConstants.TERMUX_API_APP;
+import com.termux.shared.termux.settings.preferences.TermuxAPIAppSharedPreferences;
+
+public class PluginUtils {
+
+    /**
+     * Try to get the next unique {@link PendingIntent} request code that isn't already being used by
+     * the app and which would create a unique {@link PendingIntent} that doesn't conflict with that
+     * of any other execution commands.
+     *
+     * @param context The {@link Context} for operations.
+     * @return Returns the request code that should be safe to use.
+     */
+    public synchronized static int getLastPendingIntentRequestCode(final Context context) {
+        if (context == null) return TERMUX_API_APP.DEFAULT_VALUE_KEY_LAST_PENDING_INTENT_REQUEST_CODE;
+
+        TermuxAPIAppSharedPreferences preferences = TermuxAPIAppSharedPreferences.build(context);
+        if (preferences == null) return TERMUX_API_APP.DEFAULT_VALUE_KEY_LAST_PENDING_INTENT_REQUEST_CODE;
+
+        int lastPendingIntentRequestCode = preferences.getLastPendingIntentRequestCode();
+
+        int nextPendingIntentRequestCode = lastPendingIntentRequestCode + 1;
+
+        if (nextPendingIntentRequestCode == Integer.MAX_VALUE || nextPendingIntentRequestCode < 0)
+            nextPendingIntentRequestCode = TERMUX_API_APP.DEFAULT_VALUE_KEY_LAST_PENDING_INTENT_REQUEST_CODE;
+
+        preferences.setLastPendingIntentRequestCode(nextPendingIntentRequestCode);
+        return nextPendingIntentRequestCode;
+    }
+
+}