Add GitHub Codespaces support - https://containers.dev 👀 #437
Conversation
|
I recently signed up for the site and noticed some loss of data between what I filled out during sign-up vs what was shown after verifying my e-mail. I had to re-supply a username, github uri, and linkedin uri. I didn't want to install all the dependencies on my local box so I am using this PR as a prereq to investigate the issue. I'll open an issue (and a PR with a fix if I can figure out Elixir) afterwards. |
|
This is very cool! Excuse my ignorance, but how do I give this a try in Codespaces? |
You should be able to use the "<> code" dropdown in the upper right I believe. Let me know if there are some permissions quirks since the PR comes from a fork that you don't have direct access to. |
|
Tracked down the profile data loss bug, opened #438 |
|
It works! The only thing I'm seeing as a problem is that opening the app in a browser doesn't link the assets correctly because it's using |
|
When using VS Code's desktop client it forwards the port to localhost and everything loads correctly at http://localhost:4000. I hadn't tried the VS Code web client. I'll play around with it and see if there is an easy way to get assets loading there as well. |
|
I can't find a way to detect automatically if a dev is using the VS Code web editor so the "fix" requires a manual env variable setting (see the CONTRIBUTING.md change). However, it does work after following the two steps outlined there. Developing in desktop VS Code doesn't require any extra steps. |
Signed-off-by: Chris Eggert <[email protected]>
Signed-off-by: Chris Eggert <[email protected]>
|
@all-contributors please add @pilor for code, doc |
|
I've put up a pull request to add @pilor! 🎉 |
|
This is super cool, @pilor! Thanks for contributing it. Odds are we'll discuss on Kaizen 9 🎉 |
So that contributors are not to forced for everything to build from scratch. We are also thinking of improving on those Dockerfiles so that we can make better use of op caching. All of it can be captured as code that will be used as one big CI/CD pipeline, with sweet caching. This is a follow-up to #437 Signed-off-by: Gerhard Lazu <[email protected]>
So that contributors are not to forced for everything to build from scratch. We are also thinking of improving on those Dockerfiles so that we can make better use of op caching. All of it can be captured as code that will be used as one big CI/CD pipeline, with sweet caching. This is a follow-up to thechangelog#437 Signed-off-by: Gerhard Lazu <[email protected]>
So that contributors are not to forced for everything to build from scratch. We are also thinking of improving on those Dockerfiles so that we can make better use of op caching. All of it can be captured as code that will be used as one big CI/CD pipeline, with sweet caching. This is a follow-up to #437 Signed-off-by: Gerhard Lazu <[email protected]>
|
@pilor you really started something with this one! 👏 https://changelog.fm/529 |
Adds a devcontainer spec that can be used to spin up a full Changelog development environment in a local container or in Github Codespaces.
Two containers are started (using docker compose). The first (devcontainer) includes everything in runtime.Dockerfile and is the container you land in. The second container contains Postgres.
Once the Codespace is started you start the Contributing.md instructions at the
# CONFIGURE APPsection and no additional setup is required. The app launches and is accessible atlocalhost:4000in a local browser and all tests pass.