-
Notifications
You must be signed in to change notification settings - Fork 30
Add flexsurv survival distributions and knots parameter #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should the lower range be 1L or 2L? |
|
Following up here from tidymodels/censored#115: |
On it!
I decided to include this because |
I'm going to read the source literature but do you think that we should have a dials function for the |
I proposed I can push it now and we can continue to iterate? |
Sure. |
I'm fine with It changes the link function g() between the survivor function and the spline function but given that you supply values like |
@mattwarkentin I've spoken with Max and he pointed out that |
Thanks so much for your contribution @mattwarkentin ! Looking forward to your PR on censored! |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Preliminary work relevant to tidymodels/censored#115