move mtry_prop from rules to dials

[simonpcouch]

So that bonsai need not take on a rules dependency for this parameter!

Bumping version so we can require a specific dev version of this package in rules. Will be accompanied by a PR to rules shortly. :)

[simonpcouch]

Update: I don't think bonsai actually needs to make use of the mtry_prop parameter. Leaving this and tidymodels/rules#54 open in case it's otherwise helpful to make this switch, but feel free to close if not!

[hfrick]

have we settled on the API where the default is mtry is a count but you can switch to a proportion with counts = FALSE in set_engine()? (as you did for lightgbm, and already has been done for xgboost)

If so, would it make sense to switch rules over to that API as well? It would be nice to have a consistent approach if it's the same problem. cc @topepo

[hfrick]

I spoke with Max and the plan is now:

• update rules to use the counts API tidymodels/rules#55
• move mtry_prop() from rules to dials so it's still usable/maintained but add a note that our convention is to use counts and encourage people to use that as well when developing extensions.

Could you add such a note, please?

[simonpcouch]

Thanks for the review. :) Added a docs section clarifying our convention there.

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.