Deprecate default argument
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the constructor is called in a lot of places which do not actually make use of the `default` arg
DavisVaughan
requested changes
Jul 7, 2022
|
@DavisVaughan I've addressed the comments from our review session 🙌 @topepo Max, could you also have a look at this since the PR removes the default values also for the exported parameter objects? |
DavisVaughan
approved these changes
Jul 11, 2022
Co-authored-by: Davis Vaughan <[email protected]>
for easier reading
topepo
approved these changes
Jul 11, 2022
Closed
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
defaultargument to the constructorsnew_quant_param()andnew_qual_param(). Closes #229 and closes #153.The
defaultvalue was used in a single place: when generating a sequence of parameter values of length 1 viavalue_seq(n = 1). This PR removes the special behaviour forn = 1invalue_seq()and removes all the default values for the exported parameter functions likeLaplace().The revdep checks came back clean.