Error instead of warn with wrong argument capturing the size of the grid #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: update NEWS |
simonpcouch
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I think this is a good move! Not seeing any issues testing tune locally with this PR installed, so shouldn't introduce hiccups with your release. If this warning had cropped up anywhere in our codebases and had been ignored, I'm glad we're forced to now address it.
+1 to NEWS update. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #364
I went with throwing an error instead of a warning because it seemed sufficiently important to really know when your grid wouldn't be the size you expected. My only reason not to do it would be if you anticipate this causing (too) big of a headache in a tune context.
Revdep checks are fine and extratests seem fine as well.