Skip to content

Conversation

brlin-tw
Copy link
Contributor

This allows Fcitx input method framework to be used in Gtk3 snapped apps

Signed-off-by: 林博仁(Buo-ren Lin) [email protected]

This allows Fcitx input method framework to be used in Gtk3 snapped apps

Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
Copy link
Member

@oSoMoN oSoMoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

Have you tested that this is enough to make fcitx input work in gtk3 app snaps, or is this only a prerequisite?

Wouldn't other stage packages (libfcitx-gclient1, libfcitx-utils0) be needed for this to actually work?

And if this works we would probably want to add the corresponding packages to other desktop parts (fcitx-frontend-gtk2, fcitx-frontend-qt4, fcitx-frontend-qt5).

@brlin-tw
Copy link
Contributor Author

brlin-tw commented Oct 5, 2018

Have you tested that this is enough to make fcitx input work in gtk3 app snaps, or is this only a prerequisite?

I've copied the entire part definition with this addition to one of my snap and built a sample, it works.

And if this works we would probably want to add the corresponding packages to other desktop parts (fcitx-frontend-gtk2, fcitx-frontend-qt4, fcitx-frontend-qt5).

I agree.

@oSoMoN
Copy link
Member

oSoMoN commented Oct 30, 2018

I finally got around to testing this, and I'm delighted to report that this works very nicely, no additional work needed. I successfully rebuilt the chromium snap with this additional stage package, and fcitx input (google-pinyin) just worked.

Note that snaps that connect to the gnome-3-26-1604 platform snap won't need this, for them fcitx input already works out of the box.

I also tested adding fcitx-frontend-qt5 to a qt5-based snap app (musescore), and this works well too.

@oSoMoN oSoMoN merged commit 5a5ab9f into ubuntu:master Oct 30, 2018
@oSoMoN
Copy link
Member

oSoMoN commented Oct 30, 2018

And as a follow-up I committed a264e8f to add support for fcitx in qt5-based snaps.

@brlin-tw brlin-tw deleted the patch-fix-fcitx-support branch October 30, 2018 16:36
@8none1
Copy link

8none1 commented Oct 30, 2018

Could someone test with Sogou and report back. That should be a good proof.

@brlin-tw
Copy link
Contributor Author

brlin-tw commented Nov 1, 2018

Could someone test with Sogou and report back. That should be a good proof.

What is Sogou exactly? I only heard of a Chinese company with a similar name.

@8none1
Copy link

8none1 commented Nov 1, 2018

https://pinyin.sogou.com/linux/?r=pinyin

@oSoMoN
Copy link
Member

oSoMoN commented Nov 6, 2018

Could someone test with Sogou and report back. That should be a good proof.

I confirm this works in a bionic VM. I grabbed the 64bits deb from the sogou website, installed it and its dependencies, and successfully used it in various gnome app snaps that connect to the gnome-3-26-1604 platform snap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants