-
Notifications
You must be signed in to change notification settings - Fork 59
Stage Fcitx frontend #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage Fcitx frontend #156
Conversation
This allows Fcitx input method framework to be used in Gtk3 snapped apps Signed-off-by: 林博仁(Buo-ren Lin) <[email protected]>
35fc6a3
to
50aa828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense.
Have you tested that this is enough to make fcitx input work in gtk3 app snaps, or is this only a prerequisite?
Wouldn't other stage packages (libfcitx-gclient1, libfcitx-utils0) be needed for this to actually work?
And if this works we would probably want to add the corresponding packages to other desktop parts (fcitx-frontend-gtk2, fcitx-frontend-qt4, fcitx-frontend-qt5).
I've copied the entire part definition with this addition to one of my snap and built a sample, it works.
I agree. |
I finally got around to testing this, and I'm delighted to report that this works very nicely, no additional work needed. I successfully rebuilt the chromium snap with this additional stage package, and fcitx input (google-pinyin) just worked. Note that snaps that connect to the gnome-3-26-1604 platform snap won't need this, for them fcitx input already works out of the box. I also tested adding fcitx-frontend-qt5 to a qt5-based snap app (musescore), and this works well too. |
And as a follow-up I committed a264e8f to add support for fcitx in qt5-based snaps. |
Could someone test with Sogou and report back. That should be a good proof. |
What is Sogou exactly? I only heard of a Chinese company with a similar name. |
I confirm this works in a bionic VM. I grabbed the 64bits deb from the sogou website, installed it and its dependencies, and successfully used it in various gnome app snaps that connect to the gnome-3-26-1604 platform snap. |
This allows Fcitx input method framework to be used in Gtk3 snapped apps
Signed-off-by: 林博仁(Buo-ren Lin) [email protected]