-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Create Jest project for Turbopack #73769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eps1lon
merged 1 commit into
canary
from
sebbie/12-10-create_jest_project_for_turbopack
Dec 17, 2024
Merged
Create Jest project for Turbopack #73769
eps1lon
merged 1 commit into
canary
from
sebbie/12-10-create_jest_project_for_turbopack
Dec 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
This allows running a tests for both bundlers via `pnpm test-dev test/e2e/app --projects jest.config.*`. Ideally, we'd have a `test-dev-all` shortcut. However, we can't add the test files after the `--projects` flag since it's now ambigious whether you specified a test or project config. So the `--projects` flag must come after the specified test making an NPM script using `--projects` impossible.
8160e56
to
375ed30
Compare
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
huozhi
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have sth like pnpm test-dev-all
test-prod-all
in npm script
I explained that in the PR description why I couldn't make that work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running a tests for both bundlers via
pnpm test-dev test/e2e/app --projects jest.config.*
.Ideally, we'd have a
test-dev-all
shortcut.However, we can't add the test files after the
--projects
flag since it's now ambiguous whether you specified a test or project config. So the--projects
flag must come after the specified test making an NPM script using--projects
impossible.This is mostly helpful if you want to update snapshots that are different between bundlers.