Skip to content

perf(turbopack): let some Clone be conditional in insert_alias_option #81175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jul 2, 2025

What

As the title described.

@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Jul 2, 2025
@ijjk
Copy link
Member

ijjk commented Jul 2, 2025

Allow CI Workflow Run

  • approve CI run for commit: af0c1f3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #81175 will create unknown performance changes

Comparing umijs:xusd320/perf-remove-needless-clone (af0c1f3) with canary (5efef45)

Summary

⁉️ 9 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ build[date-fns-all] 2.4 s N/A N/A
⁉️ build[date-fns-single] 1.4 s N/A N/A
⁉️ build[framer-motion-all] 3.2 s N/A N/A
⁉️ build[framer-motion-single] 2.3 s N/A N/A
⁉️ build[joy] 2.1 s N/A N/A
⁉️ build[lucide-react-all] 10.8 s N/A N/A
⁉️ build[lucide-react-single] 922 ms N/A N/A
⁉️ build[mui] 3.2 s N/A N/A
⁉️ build[shiki] 6.4 s N/A N/A

@xusd320 xusd320 changed the title perf(turbopack): let some Clone beconditional in insert_alias_option perf(turbopack): let some Clone be conditional in insert_alias_option Jul 2, 2025
Copy link
Contributor

mischnic commented Jul 2, 2025

Merge activity

  • Jul 2, 2:11 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Jul 2, 2:13 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@mischnic mischnic merged commit 07a6e5b into vercel:canary Jul 2, 2025
179 of 197 checks passed
@xusd320 xusd320 deleted the xusd320/perf-remove-needless-clone branch July 3, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants