Skip to content

Bump lightningcss to not include browserslist-rs twice #81184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Jul 2, 2025

Lightningcss still used browserslist-rs 0.18.0

Use a patch until parcel-bundler/lightningcss#1022 is merged

Closes PACK-4985

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jul 2, 2025
@mischnic mischnic marked this pull request as ready for review July 2, 2025 12:19
Copy link
Contributor Author

mischnic commented Jul 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic requested a review from a team July 2, 2025 12:20
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #81184 will degrade performances by 3.48%

Comparing mischnic/lightningcss-browserslist-dep (55cb1b4) with canary (1eb5a42)

Summary

❌ 1 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
build[lucide-react-all] 10.2 s 10.6 s -3.48%

@mischnic mischnic merged commit 6ad8a1e into canary Jul 2, 2025
161 of 167 checks passed
@mischnic mischnic deleted the mischnic/lightningcss-browserslist-dep branch July 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants