add option to shorten prompt print in log #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
requested changes
Sep 8, 2023
vllm/engine/async_llm_engine.py
Outdated
Comment on lines
244
to
246
| log_requests: bool = True, | ||
| start_engine_loop: bool = True, | ||
| max_log_len: int = None, |
There was a problem hiding this comment.
Nit: order
Suggested change
| log_requests: bool = True, | |
| start_engine_loop: bool = True, | |
| max_log_len: int = None, | |
| log_requests: bool = True, | |
| max_log_tokens: int = None, | |
| start_engine_loop: bool = True, |
vllm/engine/arg_utils.py
Outdated
Comment on lines
187
to
190
| parser.add_argument('--max_log_len', | ||
| type=int, | ||
| default=None, | ||
| help='max prompt/token being printed in log') |
There was a problem hiding this comment.
Nit:
Suggested change
| parser.add_argument('--max_log_len', | |
| type=int, | |
| default=None, | |
| help='max prompt/token being printed in log') | |
| parser.add_argument('--max-log-tokens', | |
| type=int, | |
| default=None, | |
| help='max number of prompt tokens being printed in log') |
Please rename max_log_len to max_log_tokens in other places. Thanks!
There was a problem hiding this comment.
Done for the rename
2a02926 to
a837cd3
Compare
For now, model get big context support, and there is scenario that prompt would be very long, if we also want to kept a eye over the incoming traffic, then there will be huge log created. Signed-off-by: Lei Wen <[email protected]>
a837cd3 to
cf2d0b2
Compare
zhuohan123
approved these changes
Sep 12, 2023
|
Actually, I changed the name back to "max_log_len" since for prompt string, it limits the number of characters instead of tokens. |
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Signed-off-by: Lei Wen <[email protected]> Co-authored-by: Lei Wen <[email protected]> Co-authored-by: Zhuohan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, model get big context support, and there is scenario that prompt would be very long, if we also want to kept a eye over the incoming traffic, then there will be huge log created.