Skip to content

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Dec 21, 2018

Use method.py to get a response without any body

@youennf youennf merged commit f3cbe03 into web-platform-tests:master Dec 21, 2018
@annevk
Copy link
Member

annevk commented Jan 2, 2019

@jdm
Copy link
Contributor

jdm commented Jan 2, 2019

@annevk I'm not sure I understand the question or why it's relevant.

@jdm
Copy link
Contributor

jdm commented Jan 2, 2019

Oh, the implication being that empty.txt used to somehow provide a body and was changed to method.py for this reason.

@annevk
Copy link
Member

annevk commented Jan 3, 2019

Yeah, I don't understand that change. And if it's needed presumably other files referencing empty.txt need to be modified too (or empty.txt can be removed).

@youennf
Copy link
Contributor Author

youennf commented Jan 3, 2019

Right, this is a change specific for WebKit as we are missing the empty.txt file.
I'll fix it on our side.

@youennf
Copy link
Contributor Author

youennf commented Jan 9, 2019

PR #14778 is reverting empty.txt change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants