Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xerial/snappy-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.10.0
Choose a base ref
...
head repository: xerial/snappy-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.10.1
Choose a head ref
  • 16 commits
  • 15 files changed
  • 6 contributors

Commits on May 24, 2023

  1. Trigger native lib build on PR (#444) 

    * trigger build native on PR and push

Signed-off-by: Sudip Roy <[email protected]>

* Add branch master

* Trigger native lib build only for PRs

* Test native lib build trigger

* Targetting the PR repo

* Add comment to trigger native lib build

* Fix syntax error

* Test with write permission

* Test with contents: write

* Test

* test

* Use gh pr checkout

* fix

* Add checkout phase

* test target repo:

* Try bot user

* clanup

* Use PAT

* Use different user

* simplify

* fix

* test

* Fix token

* revert

* Try push action

* use the same token

* fix tab

* Set ref

* Create a new PR for every master update

* fix

* fix indent

* Use native-all

---------

Signed-off-by: Sudip Roy <[email protected]>
Co-authored-by: Taro L. Saito <[email protected]>
    @imsudiproy @xerial
    imsudiproy and xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    10f3b32 View commit details
    Browse the repository at this point in the history

  2. internal: Run CI tests on native file change (#446)

    @xerial
    xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    3bcc1c4 View commit details
    Browse the repository at this point in the history

  3. internal: Fix commit message (#447)

    @xerial
    xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    20dd467 View commit details
    Browse the repository at this point in the history

  4. internal: Run CI tests for update-native-libs branch (#448)

    @xerial
    xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    b62a27f View commit details
    Browse the repository at this point in the history

  5. internal: Fix CI target branch (#449) 

    * internal: Run CI tests for update-native-libs branch

* Fix config

* Fix target branch
    @xerial
    xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    38bf568 View commit details
    Browse the repository at this point in the history

  6. Update native libraries for 38bf568 (#445) 

    Co-authored-by: xerial <[email protected]>
    @github-actions @xerial
    github-actions[bot] and xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    2737ea4 View commit details
    Browse the repository at this point in the history

  7. intertnal: Fix CI watch target files (#451)

    @xerial
    xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    5c35a0f View commit details
    Browse the repository at this point in the history

  8. Update native libraries for 2737ea4 (#450) 

    Co-authored-by: xerial <[email protected]>
    @github-actions @xerial
    github-actions[bot] and xerial authored May 24, 2023
    Configuration menu
    Copy the full SHA
    256691e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Update airframe-log to 23.5.6 (#453)

    @xerial-bot
    xerial-bot authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    b389544 View commit details
    Browse the repository at this point in the history

  2. Update scalafmt-core to 3.7.4 (#454)

    @xerial-bot
    xerial-bot authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    326f0b4 View commit details
    Browse the repository at this point in the history

  3. Update sbt to 1.9.0 (#455) 

    * Update sbt to 1.9.0

* Run CI on sbt upgrade

---------

Co-authored-by: Taro L. Saito <[email protected]>
    @xerial-bot @xerial
    xerial-bot and xerial authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f32d5b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Fix typo (#457) 

    * Fix typo

* Fix spacing with comment
    @aidancch
    aidancch authored Jun 6, 2023
    Configuration menu
    Copy the full SHA
    27e2ce0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge pull request from GHSA-pqr6-cmr2-h8hf 

    * Fixed integer overflow by checking if multiplication result is smaller than original value

* Fixed integer overflow by checking if multiplication result is smaller than original value

* Fixed integer overflow by checking if multiplication result is smaller than original value

* imporved error messages and added happy and sad cases for unit test in SnappyTest.java

* switched SnappyError into ILLEGAL_ARGUMENT in SnappyErrorCode.java and Snappy.java

* wrote new and updated unit test methods

* updated comments in SnappyTest.java

* Fixed and updated unit tests in SnappyTest.java
    @aidancch
    aidancch authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    820e2e0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request from GHSA-qcwq-55hx-v3vh 

    * asserted chunksize should be in the bounds of 0-java.outofmmeoryexception

* asserted chunksize should be in the bounds of 0-java.outofmmeoryexception

* https://github.com/xerial/snappy-java-ghsa-qcwq-55hx-v3vh/pull/2

* advisory-fix-3

* added and changed method name for happy and sad cases in SnappyTest.java

* removed expected error for happy case in unit testing

* added another unit test case in SnappyTest.java and fixed comments in SnappyInputStream.java

* switched SnappyError to INVALID_CHUNK_SIZE

* Updated unit tests

* Resolved conflicts with another PR merge
    @aidancch
    aidancch authored Jun 14, 2023
    1 Configuration menu
    Copy the full SHA
    3bf6785 View commit details
    Browse the repository at this point in the history

  3. Merge pull request from GHSA-fjpj-2g6w-x25r 

    * Fixed integer overflow by checking if bytesize is bigger than input length, then throwing exception

* Fixed integer overflow by checking if bytesize is bigger than input length, then throwing exception

* Fixed integer overflow by checking if bytesize is bigger than input length, then throwing exception

* improved error messages by adding new error enum INPUT_TOO_LARGE in SnappyErrorCode.java, and added happy and sad cases in SnappyTest.java

* fixed mispelling: validArrayInputLength --> isInvalidArrayInputLength

* switched SnappyError into ILLEGAL_ARGUMENT in SnappyErrorCode.java and Snappy.java and fixed a typo in error comment

* Fix buffer size boundary tests

* Remove negative array size tests

* updated comments for unit test

---------

Co-authored-by: Taro L. Saito <[email protected]>
    @aidancch @xerial
    aidancch and xerial authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d004255 View commit details
    Browse the repository at this point in the history

  4. CI Fix to Prevent Checks Dealing with Large Array Sizes (#459) 

    * Fix spacing with comment

* Updated code

* Test: Added Assume catches for each failed tests

* Added and implemented separate method to check if System CI is false

* Added a null check to ensure assumingCIIsFalse() method runs locally as well

* Changed assumeTrue to assumeFalse
    @aidancch
    aidancch authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    737f397 View commit details
    Browse the repository at this point in the history
Loading