Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-16346

Fix flaky MetricsTest.testMetrics

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 4.0.0
    • None
    • None

    Description

      Gradle Test Run :core:test > Gradle Test Executor 1119 > MetricsTest > testMetrics(boolean) > testMetrics with systemRemoteStorageEnabled: false FAILED
          org.opentest4j.AssertionFailedError: Broker metric not recorded correctly for kafka.network:type=RequestMetrics,name=MessageConversionsTimeMs,request=Produce value 0.0 ==> expected: <true> but was: <false>
              at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
              at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
              at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
              at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
              at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
              at app//kafka.api.MetricsTest.verifyBrokerMessageConversionMetrics(MetricsTest.scala:314)
              at app//kafka.api.MetricsTest.testMetrics(MetricsTest.scala:110)
      

      The value used to update metrics is calculated by Math.round, so it could be zero if you have a good machine

      We should verify the `count` instead of `value`, since it is convincible and more stable.

      Attachments

        Issue Links

          Activity

            People

              yangpoan PoAn Yang
              chia7712 Chia-Ping Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: