Support more binary assignment operators in templates #62064
Closed
+582
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the `+=`, `-=`, `*=`, `/=`, `%=`, `**=`, `&&=`, `||=` and `??=` assignment operators to the lexer.
…rser Updates the expression parser to account for the new assignment operators that were added to the lexer.
Updates the output AST to support the new set of binary operators.
Updates the remainder of the compiler to handle the new assignment operators and sets up more tests, including for the runtime.
Updates the table showing expression syntax to include the new binary operators. Also updates the table of unsupported syntax.
14 tasks
14 tasks
devversion
approved these changes
Jun 23, 2025
|
This PR was merged into the repository by commit 9974af5. The changes were merged into the following branches: main |
crisbeto
added a commit
that referenced
this pull request
Jun 23, 2025
) Updates the output AST to support the new set of binary operators. PR Close #62064
crisbeto
added a commit
that referenced
this pull request
Jun 23, 2025
Updates the remainder of the compiler to handle the new assignment operators and sets up more tests, including for the runtime. PR Close #62064
crisbeto
added a commit
that referenced
this pull request
Jun 23, 2025
Updates the table showing expression syntax to include the new binary operators. Also updates the table of unsupported syntax. PR Close #62064
princemaple
added a commit
to princemaple/ngx-html-syntax
that referenced
this pull request
Jul 12, 2025
angular/angular#62064 @deathaxe does this look about right?
princemaple
added a commit
to princemaple/ngx-html-syntax
that referenced
this pull request
Jul 12, 2025
* Support more binary assignment operators in templates angular/angular#62064 @deathaxe does this look about right? * add test * update precedence * Update NgxHTML.sublime-syntax Co-authored-by: deathaxe <[email protected]> * Update NgxHTML.sublime-syntax * augmented * test augmented * test output with assignment * fix test * test output with augmented assignment * expand selection --------- Co-authored-by: deathaxe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes expand Angular's expression syntax to support the following binary operators in templates:
+=- addition assignment-=- subtraction assignment*=- multiplication assignment/=- division assignment%=- remainder assignment**=- exponentiation assignment&&=- logical AND assignment||=- logical OR assignment??=- nullish coalescing assignment