Skip to content

perf(core): move property remapping for dom properties to compiler #62421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

perf(core): move property remapping for dom properties to compiler #62421

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 2, 2025

Since we know that DOM properties won't go to an inputs, we can move the remapping logic to the compiler, saving us some processing on the client.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 2, 2025
@angular-robot angular-robot bot added area: performance Issues related to performance area: core Issues related to the framework runtime labels Jul 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 2, 2025
@crisbeto crisbeto marked this pull request as ready for review July 2, 2025 07:57
@crisbeto
Copy link
Member Author

crisbeto commented Jul 2, 2025

Passing TGP

@crisbeto
perf(core): move property remapping for dom properties to compiler
bcada4e 
Since we know that DOM properties won't go to an inputs, we can move the remapping logic to the compiler, saving us some processing on the client.
@crisbeto crisbeto force-pushed the dom-property-remapping branch from 87c2b01 to bcada4e Compare July 2, 2025 12:04
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 2, 2025
@thePunderWoman
Copy link
Contributor

Looks like conflicts with 20.0.x. I'll switch to target: rc.

@thePunderWoman thePunderWoman added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jul 2, 2025
thePunderWoman pushed a commit that referenced this pull request Jul 2, 2025
@crisbeto @thePunderWoman
perf(core): move property remapping for dom properties to compiler (#…
56769de 
…62421)

Since we know that DOM properties won't go to an inputs, we can move the remapping logic to the compiler, saving us some processing on the client.

PR Close #62421
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 8fbe558.

The changes were merged into the following branches: main, 20.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: performance Issues related to performance target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @thePunderWoman @pkozlowski-opensource