-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][broker] Unregister non-static metrics collectors registered in Prometheus default registry #24257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-unregister-non-static-prometheus-collectors
May 6, 2025
Merged
[fix][broker] Unregister non-static metrics collectors registered in Prometheus default registry #24257
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-unregister-non-static-prometheus-collectors
May 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Prometheus default registry
heesung-sn
approved these changes
May 6, 2025
nodece
approved these changes
May 6, 2025
dao-jun
approved these changes
May 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24257 +/- ##
============================================
+ Coverage 73.57% 74.18% +0.61%
+ Complexity 32624 32202 -422
============================================
Files 1877 1866 -11
Lines 139502 144978 +5476
Branches 15299 16561 +1262
============================================
+ Hits 102638 107552 +4914
- Misses 28908 28922 +14
- Partials 7956 8504 +548
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit 218c9c5)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit 218c9c5)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
manas-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit b44db02)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d) (cherry picked from commit 218c9c5)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 28, 2025
…Prometheus default registry (apache#24257) (cherry picked from commit 9cf821d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
area/test
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.12
release/3.3.7
release/4.0.5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For upgrading Mockito to 5.17, it's necessary that already shutdown Pulsar broker test instances don't get referenced later. This is due to the way how Mockito mocks are cleaned up after each test. In newer Mockito versions, an exception will be thrown if such accesses happen.
Most metric collectors are static in Pulsar, but there are 2 instances in the broker where the collector dynamically gets the value. These should be unregistered at shutdown.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete