fix(pdata/plog): unmarshal event_name from json #13123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Jun 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13123 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 508 508
Lines 28747 28749 +2
=======================================
+ Hits 26235 26237 +2
Misses 1994 1994
Partials 518 518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please add a changelog entry |
auto-merge was automatically disabled
June 2, 2025 06:27
Head branch was pushed to by a user without write access
Thank you for the review! I added the changelog entry. |
5f69db2 to
042a30d
Compare
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 5, 2025
#### Description This PR adds missing logic to process `event_name` field when unmarshaling LogRecords from JSON. #### Testing Added `eventName` to json (un)marshal tests. Fixes open-telemetry#13127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing logic to process
event_namefield when unmarshaling LogRecords from JSON.Testing
Added
eventNameto json (un)marshal tests.Fixes #13127