Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-auth-library-nodejs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.1
Choose a base ref
...
head repository: googleapis/google-auth-library-nodejs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Apr 27, 2022

  1. fix: Fixing Implementation of GoogleAuth.sign() for external account … 

    …credentials (#1397)

* fix: Fixing Implementation of GoogleAuth.sign() for external account credentials

Currently, creating signed storage URLs does not work for external account credentials because the storage library expects client_email to be returned from GoogleAuth.getCredentials(). Changing the logic so the same client email that is used to the sign the blob (extracted from the Service Account Impersonation URL) is returned from the getCredentials() call.

Fixes #1239

* addressing code review comments

* addressing code review comments
    @aeitzman
    aeitzman authored Apr 27, 2022
    Configuration menu
    Copy the full SHA
    b0ddb75 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. chore(main): release 8.0.2 (#1401) 

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    @release-please
    release-please[bot] authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    003df0f View commit details
    Browse the repository at this point in the history
Loading