Skip to content

Commit 92b503a

Browse files
adamchainztswast
andauthored
fix: remove libcst as a required dependency (#389)
* Remove libcst dependency libcst is only used for a one-off "fixup" script. It’s not necessary to always depend on it. It caused an issue on one project as old libcst versions don't ship macOS M1 wheels, and it took time to figure this out. (Also the instructions for using the fixup script were incorrect.) * Update UPGRADING.md Co-authored-by: Tim Swast <[email protected]>
1 parent 16520e3 commit 92b503a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

UPGRADING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,12 @@ wrapper around the auto-generated `read_rows()` method.
132132
python3 -m pip install google-cloud-bigquery-storage
133133
```
134134

135-
* The script `fixup_storage_v1_keywords.py` is shipped with the library. It expects
136-
an input directory (with the code to convert) and an empty destination directory.
135+
* The script `fixup_bigquery_storage_v1_keywords.py` is shipped with the library. It
136+
requires `libcst` to be installed. It expects an input directory (with the code
137+
to convert) and an empty destination directory.
137138

138139
```sh
139-
$ scripts/fixup_storage_v1_keywords.py --input-directory .samples/ --output-directory samples/
140+
$ fixup_bigquery_storage_v1_keywords.py --input-directory .samples/ --output-directory samples/
140141
```
141142

142143
**Before:**

setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
# https://github.com/googleapis/google-cloud-python/issues/10566
3030
"google-api-core[grpc] >= 1.28.0, <3.0.0dev",
3131
"proto-plus >= 1.18.0",
32-
"libcst >= 0.2.5",
3332
]
3433
extras = {
3534
"pandas": ["pandas>=0.21.1"],

0 commit comments

Comments
 (0)