Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.19.0
Choose a base ref
...
head repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.19.1
Choose a head ref
  • 7 commits
  • 47 files changed
  • 3 contributors

Commits on Oct 21, 2021

  1. Ensure that release archives contain everything needed for Bazel (#9131)

    This change adds some files to EXTRA_DIST in Makefile.am so that our
    published tar and zip files will have everything needed for Bazel
    builds. I also added a basic test for this so that next time we should
    find out sooner if we're missing any important files.
    
    This should fix #9129.
    acozzette authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    67c2a92 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Align dependency handling with Bazel best practices (#9165)

    This commit removes the use of bind() since that function goes against
    Bazel best practices:
    https://docs.bazel.build/versions/main/external.html#repository-rules-1
    The bind() function basically maps a dependency into //external, but
    there is no good reason to do this. By mapping dependencies into
    //external and relying on this in our own BUILD files, we're forcing
    projects that depend on us to do the same. The one bind() call that I
    did leave in place was //:python_headers. This one seems to be doing
    something complicated I don't fully understand, and I don't want to risk
    breaking it.
    
    This change also moves our list of required Maven artifacts into a
    constant in protobuf_deps.bzl. This way, projects that depend on us can
    refer to this list when they invoke maven_install() and automatically
    pull in all the necesary dependencies.
    
    This fixes #9132.
    acozzette authored Oct 28, 2021
    4 Configuration menu
    Copy the full SHA
    c7dfd0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e58469b View commit details
    Browse the repository at this point in the history
  3. Fix memory leak in MessageClass.encode

    If the line above raises an exception, the upb_arena is lost and memory
    is leaked.
    peterzhu2118 authored and acozzette committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    b2ac7ce View commit details
    Browse the repository at this point in the history
  4. Update changelog for 3.19.1

    I also updated CHANGES.txt to include a couple things I forgot to add
    for 3.19.0.
    acozzette committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    1c8ae24 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #9166 from acozzette/cherry-pick-fixes

    Cherry-pick fixes for 3.19.1 and update change log
    acozzette authored Oct 28, 2021
    Configuration menu
    Copy the full SHA
    42ff92a View commit details
    Browse the repository at this point in the history
  6. 3 Configuration menu
    Copy the full SHA
    7c40b2d View commit details
    Browse the repository at this point in the history
Loading