-
Notifications
You must be signed in to change notification settings - Fork 15.8k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.19.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.19.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 47 files changed
- 3 contributors
Commits on Oct 21, 2021
-
Ensure that release archives contain everything needed for Bazel (#9131)
This change adds some files to EXTRA_DIST in Makefile.am so that our published tar and zip files will have everything needed for Bazel builds. I also added a basic test for this so that next time we should find out sooner if we're missing any important files. This should fix #9129.
Configuration menu - View commit details
-
Copy full SHA for 67c2a92 - Browse repository at this point
Copy the full SHA 67c2a92View commit details
Commits on Oct 28, 2021
-
Align dependency handling with Bazel best practices (#9165)
This commit removes the use of bind() since that function goes against Bazel best practices: https://docs.bazel.build/versions/main/external.html#repository-rules-1 The bind() function basically maps a dependency into //external, but there is no good reason to do this. By mapping dependencies into //external and relying on this in our own BUILD files, we're forcing projects that depend on us to do the same. The one bind() call that I did leave in place was //:python_headers. This one seems to be doing something complicated I don't fully understand, and I don't want to risk breaking it. This change also moves our list of required Maven artifacts into a constant in protobuf_deps.bzl. This way, projects that depend on us can refer to this list when they invoke maven_install() and automatically pull in all the necesary dependencies. This fixes #9132.
4Configuration menu - View commit details
-
Copy full SHA for c7dfd0d - Browse repository at this point
Copy the full SHA c7dfd0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e58469b - Browse repository at this point
Copy the full SHA e58469bView commit details -
Fix memory leak in MessageClass.encode
If the line above raises an exception, the upb_arena is lost and memory is leaked.
Configuration menu - View commit details
-
Copy full SHA for b2ac7ce - Browse repository at this point
Copy the full SHA b2ac7ceView commit details -
I also updated CHANGES.txt to include a couple things I forgot to add for 3.19.0.
Configuration menu - View commit details
-
Copy full SHA for 1c8ae24 - Browse repository at this point
Copy the full SHA 1c8ae24View commit details -
Merge pull request #9166 from acozzette/cherry-pick-fixes
Cherry-pick fixes for 3.19.1 and update change log
Configuration menu - View commit details
-
Copy full SHA for 42ff92a - Browse repository at this point
Copy the full SHA 42ff92aView commit details -
3
Configuration menu - View commit details
-
Copy full SHA for 7c40b2d - Browse repository at this point
Copy the full SHA 7c40b2dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.19.0...v3.19.1