Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

fix: prevent unchecked warnings in gax-httpjson [gax-java] #1306

Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix: prevent unchecked warnings in gax-httpjson [gax-java] #1306

merged 2 commits into from
Feb 18, 2021

Conversation

miraleung
Copy link
Contributor

Closes #1305.

@miraleung miraleung requested a review from elharo February 18, 2021 02:48
@miraleung miraleung requested review from a team as code owners February 18, 2021 02:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #1306 (0148b28) into master (a8d3a2d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1306      +/-   ##
============================================
+ Coverage     79.53%   79.57%   +0.03%     
- Complexity     1239     1240       +1     
============================================
  Files           209      209              
  Lines          5434     5434              
  Branches        454      454              
============================================
+ Hits           4322     4324       +2     
+ Misses          933      932       -1     
+ Partials        179      178       -1
Impacted Files Coverage Δ Complexity Δ
...i/gax/httpjson/ApiMessageHttpRequestFormatter.java 74.07% <ø> (ø) 10.00 <0.00> (ø)
...m/google/api/gax/httpjson/ApiMethodDescriptor.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
.../java/com/google/api/gax/batching/BatcherImpl.java 98.06% <0.00%> (+1.29%) 17.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d3a2d...4e5e8a3. Read the comment docs.

vam-google
vam-google approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miraleung miraleung merged commit ee370f6 into master Feb 18, 2021
@miraleung miraleung deleted the fix/unchecked branch February 18, 2021 19:35
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 25, 2021
@release-please
chore(master): release 1.62.0 (#1316)
6b12d3e 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.62.0](https://www.github.com/googleapis/gax-java/compare/v1.61.0...v1.62.0) (2021-02-25)


### Features

* deprecate RetrySettings.isJittered [gax-java] ([#1308](https://www.github.com/googleapis/gax-java/issues/1308)) ([68644a4](https://www.github.com/googleapis/gax-java/commit/68644a4e24f29223f8f533a3d353dff7457d9737))
* dynamic flow control part 1 - add FlowController to Batcher ([#1289](https://www.github.com/googleapis/gax-java/issues/1289)) ([bae5eb6](https://www.github.com/googleapis/gax-java/commit/bae5eb6070e690c26b95e7b908d15300aa54ef1c))


### Bug Fixes

* prevent unchecked warnings in gax-httpjson ([#1306](https://www.github.com/googleapis/gax-java/issues/1306)) ([ee370f6](https://www.github.com/googleapis/gax-java/commit/ee370f62c5d411738a9b25cf4cfc095aa06d9e07))
* remove unused @InternalExtensionOnly from CallContext classes ([#1304](https://www.github.com/googleapis/gax-java/issues/1304)) ([a8d3a2d](https://www.github.com/googleapis/gax-java/commit/a8d3a2dca96efdb1ce154a976c3e0844e3f501d6))


### Dependencies

* update google-auth-library to 0.24.0 ([#1315](https://www.github.com/googleapis/gax-java/issues/1315)) ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
* update google-common-protos to 2.0.1 ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
* update google-http-client to 1.39.0 ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
* update google-iam ([#1313](https://www.github.com/googleapis/gax-java/issues/1313)) ([327b53c](https://www.github.com/googleapis/gax-java/commit/327b53ca7739d9be6e24305b23af2c7a35cb6f4d))
* update gRPC to 1.36.0 ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
* update opencensus to 0.28.0 ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
* update protobuf to 3.15.2 ([772331e](https://www.github.com/googleapis/gax-java/commit/772331eda5c47e9de376e505e7d8ee502b01ec72))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vam-google vam-google vam-google approved these changes

@elharo elharo Awaiting requested review from elharo

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle emits unchecked warnings for gax-httpjson
2 participants
@miraleung @vam-google