Skip to content

feat: add reservation usage in job statistics #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat: add reservation usage in job statistics #1018

merged 1 commit into from
Feb 5, 2021

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Dec 11, 2020 •
edited by stephaniewang526
Loading

Fixes #1087

@pmakani pmakani requested review from shollyman, stephaniewang526 and a team December 11, 2020 10:34
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Dec 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020 •
edited
Loading

Codecov Report

Merging #1018 (50c3e85) into master (93ea6fb) will decrease coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1018      +/-   ##
============================================
- Coverage     80.18%   80.12%   -0.06%     
  Complexity     1268     1268              
============================================
  Files            79       79              
  Lines          6576     6617      +41     
  Branches        760      765       +5     
============================================
+ Hits           5273     5302      +29     
- Misses          910      917       +7     
- Partials        393      398       +5
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/bigquery/JobStatistics.java 89.45% <71.42%> (-1.86%) 16.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ea6fb...50c3e85. Read the comment docs.

@stephaniewang526 stephaniewang526 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 11, 2020
@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Dec 11, 2020 •
edited
Loading

As discussed with @shollyman off-line, we will wait for a bug fix related to cost control. Otherwise, LGTM.

@stephaniewang526 stephaniewang526 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 5, 2021
@stephaniewang526 stephaniewang526 merged commit 49cbb0f into googleapis:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery Feature: reservation usage in job statistics
2 participants
@pmakani @stephaniewang526