feat: add debug statement to StandardTableDefinition #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Jan 27, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
Outdated
Show resolved
Hide resolved
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableDefinition.java
Outdated
Show resolved
Hide resolved
tswast
reviewed
Jan 27, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
============================================
+ Coverage 77.38% 77.43% +0.05%
Complexity 1110 1110
============================================
Files 73 73
Lines 5916 5930 +14
Branches 645 645
============================================
+ Hits 4578 4592 +14
Misses 1013 1013
Partials 325 325
Continue to review full report at Codecov.
|
pmakani
reviewed
Jan 28, 2020
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/StandardTableDefinitionTest.java
Outdated
Show resolved
Hide resolved
tswast
approved these changes
Jan 28, 2020
tswast
reviewed
Jan 28, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
Outdated
Show resolved
Hide resolved
tswast
reviewed
Jan 28, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
Outdated
Show resolved
Hide resolved
[WARNING] Used undeclared dependencies found: [WARNING] org.hamcrest:hamcrest-core:jar:1.3:test
tswast
approved these changes
Jan 28, 2020
tswast
approved these changes
Jan 28, 2020
shollyman
approved these changes
Jan 28, 2020
chingor13
pushed a commit
that referenced
this pull request
Jan 28, 2020
* chore: add debug statement to StandardTableDefinition * update to include cause * remove changes to method headers * update base on comment * adding testcase * adding testcases * fix test dep build error [WARNING] Used undeclared dependencies found: [WARNING] org.hamcrest:hamcrest-core:jar:1.3:test * update to add more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugs b/148288889