Skip to content

Conversation

prash-mi
Copy link
Contributor

Added retry logic on java.net.ConnectException and java.net.UnknownHostException for BigQueryImpl.listDatasets() and BigQueryImpl.queryRpc() methods

Fixes # #1254 and googleapis/gax-java#1301 ☕️

@prash-mi prash-mi requested review from a team and stephaniewang526 June 13, 2021 05:48
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jun 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2021
@@ -0,0 +1,36 @@
/*
* Copyright 2015 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright 2015 Google LLC
* Copyright 2021 Google LLC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Jun 14, 2021

Hi Prashant, please update the PR subject and initial commit to fix: handle specific exceptions -- we follow conventionalcommits standards.
Also, please run linter: mvn com.coveo:fmt-maven-plugin:format to clear the lint failure.

@prash-mi prash-mi changed the title Bug Fixes: fix: handle specific exceptions Jun 15, 2021
@prash-mi
Copy link
Contributor Author

Hi Stephanie,

I have updated the subject and have fixed the linting error. Please let me know if you see any further issues.

Regards,
Prashant

@stephaniewang526 stephaniewang526 merged commit 68808e9 into googleapis:master Jun 15, 2021
@prash-mi prash-mi deleted the bigquery-bug-fixes branch June 17, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants