Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Feb 18, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2020
@pmakani pmakani changed the title feat : expose location field of model feat: expose location field of model Feb 18, 2020
@pmakani pmakani force-pushed the model-location-field branch from 107c0b0 to 62859ef Compare February 18, 2020 12:45
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #175 into master will decrease coverage by 0.08%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
- Coverage     77.49%   77.41%   -0.09%     
- Complexity     1113     1114       +1     
============================================
  Files            73       73              
  Lines          5941     5941              
  Branches        646      636      -10     
============================================
- Hits           4604     4599       -5     
- Misses         1011     1012       +1     
- Partials        326      330       +4
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12 <0> (ø)
...main/java/com/google/cloud/bigquery/ModelInfo.java 77.21% <87.5%> (+0.54%) 24 <1> (+1) ⬆️
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.5% <0%> (-0.62%) 44% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.68% <0%> (-0.48%) 52% <0%> (ø)
...a/com/google/cloud/bigquery/InsertAllResponse.java 88.88% <0%> (-0.31%) 15% <0%> (ø)
...m/google/cloud/bigquery/QueryJobConfiguration.java 76.85% <0%> (-0.29%) 56% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Field.java 82.6% <0%> (-0.19%) 25% <0%> (ø)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 66.84% <0%> (-0.18%) 58% <0%> (ø)
...google/cloud/bigquery/StandardTableDefinition.java 93.75% <0%> (-0.16%) 16% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.23% <0%> (+0.03%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5212b2f...62859ef. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2020
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@stephaniewang526 stephaniewang526 merged commit 646c2b4 into googleapis:master Feb 18, 2020
@pmakani pmakani deleted the model-location-field branch February 19, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants