Skip to content

fix: parentjobid in listjobs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

fix: parentjobid in listjobs #20

merged 1 commit into from
Dec 10, 2019

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Dec 10, 2019

Fixes #18

@pmakani pmakani requested a review from shollyman December 10, 2019 06:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited
Loading

Codecov Report

Merging #20 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     77.36%   77.34%   -0.02%     
  Complexity     1106     1106              
============================================
  Files            73       73              
  Lines          5906     5907       +1     
  Branches        644      644              
============================================
  Hits           4569     4569              
- Misses         1011     1012       +1     
  Partials        326      326
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.21% <0%> (-0.02%) 2 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4a6eb...bb8cb43. Read the comment docs.

@stephaniewang526 stephaniewang526 self-requested a review December 10, 2019 15:47
@stephaniewang526 stephaniewang526 merged commit 1b0b21b into googleapis:master Dec 10, 2019
@pmakani pmakani deleted the bigquery-18 branch December 11, 2019 08:57
@elharo elharo mentioned this pull request Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery.JobListOption.parentJobId does not seem to work
3 participants
@pmakani @stephaniewang526 @googlebot