Skip to content

Conversation

stephaniewang526
Copy link
Contributor

Fixes b/146052864

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@841d075). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   77.29%           
  Complexity        ?     1107           
=========================================
  Files             ?       73           
  Lines             ?     5901           
  Branches          ?      635           
=========================================
  Hits              ?     4561           
  Misses            ?     1010           
  Partials          ?      330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841d075...61494ff. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix the dependencies test as well.

@BenWhitehead
Copy link

We also need to disable release for the sample module. @chingor13 How do we do that with the current setup of things.

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #23 to track figuring out the release config

@stephaniewang526 stephaniewang526 merged commit f0bdc4d into master Dec 12, 2019
@stephaniewang526 stephaniewang526 deleted the feat-migrate-samples branch December 12, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants