Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 13, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team July 13, 2020 09:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2020
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #538 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #538      +/-   ##
============================================
+ Coverage     81.43%   81.49%   +0.06%     
  Complexity     1226     1226              
============================================
  Files            77       77              
  Lines          6210     6220      +10     
  Branches        681      691      +10     
============================================
+ Hits           5057     5069      +12     
- Misses          790      792       +2     
+ Partials        363      359       -4     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.20% <0.00%> (-0.04%) 2.00% <0.00%> (ø%)
...src/main/java/com/google/cloud/bigquery/Field.java 83.49% <0.00%> (+0.16%) 27.00% <0.00%> (ø%)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.59% <0.00%> (+0.17%) 74.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.33% <0.00%> (+0.18%) 16.00% <0.00%> (ø%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 90.08% <0.00%> (+0.27%) 66.00% <0.00%> (ø%)
...a/com/google/cloud/bigquery/InsertAllResponse.java 89.18% <0.00%> (+0.30%) 15.00% <0.00%> (ø%)
...om/google/cloud/bigquery/LoadJobConfiguration.java 93.20% <0.00%> (+0.43%) 56.00% <0.00%> (ø%)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.81% <0.00%> (+0.57%) 46.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cee131...1f7d0df. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 3f129a6 into googleapis:master Jul 13, 2020
@pmakani pmakani deleted the extract-compressed-table branch July 14, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants