Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 23, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team July 23, 2020 10:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #587   +/-   ##
=========================================
  Coverage     81.49%   81.49%           
  Complexity     1226     1226           
=========================================
  Files            77       77           
  Lines          6220     6220           
  Branches        691      691           
=========================================
  Hits           5069     5069           
  Misses          792      792           
  Partials        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3621df...a6b7cf8. Read the comment docs.

@pmakani pmakani added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@stephaniewang526 stephaniewang526 merged commit 55cd52c into googleapis:master Jul 23, 2020
@pmakani pmakani deleted the query-dryrun branch July 24, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants