Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 27, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team July 27, 2020 12:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #603 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #603      +/-   ##
============================================
- Coverage     81.49%   81.43%   -0.07%     
  Complexity     1226     1226              
============================================
  Files            77       77              
  Lines          6220     6210      -10     
  Branches        691      681      -10     
============================================
- Hits           5069     5057      -12     
+ Misses          792      790       -2     
- Partials        359      363       +4     
Impacted Files Coverage Δ Complexity Δ
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.23% <0.00%> (-0.58%) 46.00% <0.00%> (ø%)
...om/google/cloud/bigquery/LoadJobConfiguration.java 92.77% <0.00%> (-0.44%) 56.00% <0.00%> (ø%)
...a/com/google/cloud/bigquery/InsertAllResponse.java 88.88% <0.00%> (-0.31%) 15.00% <0.00%> (ø%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 89.80% <0.00%> (-0.28%) 66.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.15% <0.00%> (-0.19%) 16.00% <0.00%> (ø%)
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.42% <0.00%> (-0.18%) 74.00% <0.00%> (ø%)
...src/main/java/com/google/cloud/bigquery/Field.java 83.33% <0.00%> (-0.17%) 27.00% <0.00%> (ø%)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.23% <0.00%> (+0.03%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc5bc3...0e52904. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 1eeffe6 into googleapis:master Jul 27, 2020
@pmakani pmakani deleted the query_params_arrays branch July 28, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants