feat: add delimiter BlobListOption #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
============================================
+ Coverage 63.30% 63.62% +0.32%
- Complexity 528 539 +11
============================================
Files 30 30
Lines 4720 4729 +9
Branches 450 426 -24
============================================
+ Hits 2988 3009 +21
+ Misses 1571 1562 -9
+ Partials 161 158 -3
Continue to review full report at Codecov.
|
frankyn
reviewed
Feb 7, 2020
| @@ -988,6 +988,11 @@ public static BlobListOption currentDirectory() { | |||
| return new BlobListOption(StorageRpc.Option.DELIMITER, true); | |||
| } | |||
|
|
|||
| /** Returns an option to set a delimiter '/'. */ | |||
| public static BlobListOption delimiter() { | |||
There was a problem hiding this comment.
Delimiter can be user defined, generally '/' is the one used most often, but I'd like to keep this open to other delimiters.
|
@frankyn PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99