Skip to content
This repository was archived by the owner on Oct 14, 2023. It is now read-only.

fix: increase batch translate timeout to 300 #274

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

munkhuushmgl
Copy link
Contributor

@munkhuushmgl munkhuushmgl commented Aug 26, 2020

Fixes #267 ☕️

average time batch translate LRO to complete is between 1-3min but sometimes it takes 4-5 min to complete.

@munkhuushmgl munkhuushmgl requested a review from a team August 26, 2020 20:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     69.90%   69.90%           
  Complexity      220      220           
=========================================
  Files            23       23           
  Lines          1668     1668           
  Branches         46       46           
=========================================
  Hits           1166     1166           
  Misses          457      457           
  Partials         45       45           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a997d2...1685bb0. Read the comment docs.

@munkhuushmgl munkhuushmgl merged commit 75736fe into master Aug 26, 2020
@munkhuushmgl munkhuushmgl deleted the translate-timeout branch August 26, 2020 22:36
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 30, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.95.3](https://www.github.com/googleapis/java-translate/compare/v1.95.2...v1.95.3) (2020-10-30)


### Bug Fixes

* increase batch translate timeout to 300 ([#274](https://www.github.com/googleapis/java-translate/issues/274)) ([75736fe](https://www.github.com/googleapis/java-translate/commit/75736fe03ee1298ee153ce9baeb8c81ec82df8a0))
* use setModel as rest api already support it ([#330](https://www.github.com/googleapis/java-translate/issues/330)) ([de5b5a8](https://www.github.com/googleapis/java-translate/commit/de5b5a80fb9e42cf698fd101cffd34474eda0ce9))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#318](https://www.github.com/googleapis/java-translate/issues/318)) ([41293ce](https://www.github.com/googleapis/java-translate/commit/41293ce8a0e6cb410ba0f4a80a8027bc5ee49b3d))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#281](https://www.github.com/googleapis/java-translate/issues/281)) ([e028946](https://www.github.com/googleapis/java-translate/commit/e02894607fea4edaa04486709a0e438a5f5beb20))
* update dependency com.google.cloud:google-cloud-storage to v1.113.2 ([#277](https://www.github.com/googleapis/java-translate/issues/277)) ([ed76cd5](https://www.github.com/googleapis/java-translate/commit/ed76cd53a5a2db0214b1c0986009c7cee7428384))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.example.translate.BatchTranslateTextWithModelTests: testBatchTranslateTextWithModel failed
2 participants