Skip to content

Commit cbf16f8

Browse files
fix: Change type hint on callback to be Callback. (#135)
The overrides library doesn't like the Callable type and breaks. mkorpela/overrides#78
1 parent 75731f0 commit cbf16f8

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

google/cloud/pubsublite/cloudpubsub/internal/multiplexed_subscriber_client.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414

1515
from concurrent.futures.thread import ThreadPoolExecutor
16-
from typing import Union, Optional, Set
16+
from typing import Union, Optional, Set, Callable, cast
1717

1818
from google.cloud.pubsub_v1.subscriber.futures import StreamingPullFuture
1919

@@ -61,12 +61,13 @@ def cancel_streaming_pull_future(fut: StreamingPullFuture):
6161
def subscribe(
6262
self,
6363
subscription: Union[SubscriptionPath, str],
64-
callback: MessageCallback,
64+
callback: Callable, # TODO(dpcollins): Change to MessageCallback,
6565
per_partition_flow_control_settings: FlowControlSettings,
6666
fixed_partitions: Optional[Set[Partition]] = None,
6767
) -> StreamingPullFuture:
6868
if isinstance(subscription, str):
6969
subscription = SubscriptionPath.parse(subscription)
70+
callback = cast(MessageCallback, callback)
7071

7172
def create_and_open():
7273
underlying = self._underlying_factory(

google/cloud/pubsublite/cloudpubsub/subscriber_client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414

1515
from concurrent.futures.thread import ThreadPoolExecutor
16-
from typing import Optional, Union, Set, AsyncIterator
16+
from typing import Optional, Union, Set, AsyncIterator, Callable
1717

1818
from google.api_core.client_options import ClientOptions
1919
from google.auth.credentials import Credentials
@@ -33,7 +33,6 @@
3333
from google.cloud.pubsublite.cloudpubsub.nack_handler import NackHandler
3434
from google.cloud.pubsublite.cloudpubsub.subscriber_client_interface import (
3535
SubscriberClientInterface,
36-
MessageCallback,
3736
AsyncSubscriberClientInterface,
3837
)
3938
from google.cloud.pubsublite.internal.constructable_from_service_account import (
@@ -100,7 +99,7 @@ def __init__(
10099
def subscribe(
101100
self,
102101
subscription: Union[SubscriptionPath, str],
103-
callback: MessageCallback,
102+
callback: Callable, # TODO(dpcollins): Change to MessageCallback,
104103
per_partition_flow_control_settings: FlowControlSettings,
105104
fixed_partitions: Optional[Set[Partition]] = None,
106105
) -> StreamingPullFuture:

google/cloud/pubsublite/cloudpubsub/subscriber_client_interface.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class SubscriberClientInterface(ContextManager):
8181
def subscribe(
8282
self,
8383
subscription: Union[SubscriptionPath, str],
84-
callback: MessageCallback,
84+
callback: Callable, # TODO(dpcollins): Change to MessageCallback,
8585
per_partition_flow_control_settings: FlowControlSettings,
8686
fixed_partitions: Optional[Set[Partition]] = None,
8787
) -> StreamingPullFuture:

0 commit comments

Comments
 (0)