feat: add timeouts to Blob methods where missing #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemangChothani
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
LGTM! I think need a googleapis/google-resumable-media-python#116 PR to merge first and release google-resumable-media.
|
@HemangChothani Indeed, that's the PR linked in the PR description. We need to wait for it to be released before this one can be merged. |
|
The related resumable media PR has been merged, now just awaiting a new release to unblock this one. |
|
@plamut I have just approved the release PR for |
tseaver
approved these changes
Jul 21, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add timeouts to Blob methods where missing * Require google-resumable-media version 0.6.0+
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* feat: add timeouts to Blob methods where missing * Require google-resumable-media version 0.6.0+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #183.
This PR adds customizable timeouts to various
Blobmethods that previously didn't have that, because the underlying dependencygoogle-resumable-media-pythonlacked support for it.There is a resumable media PR that will add that support, and this PR depends on it. We need to wait until that gets merged and released.
PR checklist