Skip to content

fix: preserve metadata value #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2020
Merged

fix: preserve metadata value #298

merged 4 commits into from
Nov 11, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #293

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@frankyn frankyn requested review from andrewsg and removed request for frankyn October 21, 2020 16:35
@frankyn
Copy link
Contributor

frankyn commented Oct 21, 2020

@andrewsg PTAL when you have a moment.

tseaver
tseaver suggested changes Oct 21, 2020
View reviewed changes
@HemangChothani
Copy link
Contributor Author

@tseaver PTAL!

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5ab6b0d into googleapis:master Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: preserve metadata value (googleapis#298)
1cb663b 
Fixes googleapis#293
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: preserve metadata value (googleapis#298)
16145e4 
Fixes googleapis#293
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@andrewsg andrewsg Awaiting requested review from andrewsg

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob.metadata not preserved when uploading new file content
3 participants
@HemangChothani @frankyn @tseaver