docs: revise docstrings for generate_signed_url #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
|
I really suck with Git, sorry for that. Apparently, there is something wrong with my commit messages, but you got the idea... |
cojenco
approved these changes
Apr 19, 2021
frankyn
approved these changes
Apr 19, 2021
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Adjusting comment for accuracy The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is. * fix: adjusting comment for accuracy The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is. Co-authored-by: cojenco <[email protected]>
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Adjusting comment for accuracy The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is. * fix: adjusting comment for accuracy The assumed property is `signer_email` and not `service_account_email`. In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is. Co-authored-by: cojenco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumed property is
signer_emailand notservice_account_email.In nowhere a property called
service_account_emailis read fromcredentials, butsigner_emailis.Fixes #406 🦕