feat: add timeout parameter to public methods #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
System tests CI failure seems to be temporary (503 ServiceUnavailable). |
crwilcox
approved these changes
Feb 11, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Add a default request timeout constant * Add timeout to ACL public methods * Add timeout to Blob methods * Add default timeout to Batch._do_request() * Add timeout to Bucket methods * Add timeout to Client methods * Add timeout to HMACKeyMetadata methods * Add timeout to BucketNotification methods * Add timeout to _PropertyMixin helpers
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
* Add a default request timeout constant * Add timeout to ACL public methods * Add timeout to Blob methods * Add default timeout to Batch._do_request() * Add timeout to Bucket methods * Add timeout to Client methods * Add timeout to HMACKeyMetadata methods * Add timeout to BucketNotification methods * Add timeout to _PropertyMixin helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6.
Closes #13.
A replacement for the same PR in the old repo.
Notes
ACL._ensure_loaded()has a default timeout, but not all internal calls to it can be made that configurable, such as inACL.__iter__(). I thus left that part to use a default timeout.Blob.download_to_file(),Blob.upload_from_file(), and the methods that rely on these two do not expose timeouts, because the underlyingresumable-medialogic applies its own default timeout totransport.request(), which would override user timeouts.Getting around that would first require adding configurable timeouts to the
resumable-mediadependency (there is a PR #116 that adds these, but only for uploads and it's not merged yet) .PR checklist: