Code review
4 likes6,416 views
This document discusses how to improve software quality through code reviews. It begins by stating the goals of code review, such as improving code quality, sharing knowledge, and educating developers. It then discusses classification of code reviews from less to more formal. The document outlines some best practices for code reviews, including having a reviewer and author, choosing reviewers strategically, and driving the review in different ways. It provides answers to common questions about organizing effective code reviews and leaves with tips, such as tracking reviewers, using checklists, and ensuring comfortable conditions for all.
Code review
- 1. How to improve quality of the product using βcode reviewβMikalai alimenkouAleksey solntsev
- 2. Alimenkou MikalaiJava Technical Lead/Scrum Master at Zoral Labs6+ years in software development4+ years of working by Agile methodologiesExpert in Agile engineering practicesAgile coachΒ at XP InjectionSolntsev AlekseyProcess Architect at Infopulse Ukraine
- 5. Initiator and coordinator of translation of the cult book "Scrum and XP from the Trenches" into Russian
- 6. Agile coachΒ at XP InjectionAgendaIntroduction and common principlesWhyCode Review works?WhyCode Reviewcouldnβt work?How to find reviewer?Practices, metrics, tips and tricks
- 7. Where is quality better?
- 8. Goals of code reviewImprove quality of code
- 10. Improve collective code ownership
- 13. Educate
- 15. Try other approachesClassificationLess formalMost formal
- 16. Common principles: rolesThird personsA reviewerAn author
- 17. 3main reasons why code review works
- 18. Two pair of eyes are better then one
- 21. reasons why code review couldnβt work3
- 23. βEgoβ effect
- 25. 7strategies how to choose a reviewer
- 26. 1. Β«Daddy at homeΒ»
- 30. 5. Β«SWATΒ»
- 33. 2ways to drivecode review
- 34. 1. ATR (Author driver review)Yep, yepIβve added a couple of new interfaces. There are the implementation.A reviewerAn author
- 35. 2. RTR (Reviewer driven review)Hmmβ¦ I donβt understand what you try to verify using this test.Actually, Iβm also a little bit confused β¦A reviewerAn author
- 37. What should we start with?A reviewer
- 38. What to review?Look at code changes/differencesReview whole solutionIdentify methods/functions and classes
- 39. How to organize code review?Use changes package (email, patch, etc.)Use separate branch in VCSUse distributed VCSCode exchange tools built in IDESpecialized instruments
- 40. How to organize code review?
- 41. Should we use metrics?
- 42. How long?60
- 43. Fast or slow?500
- 44. Big or small commits?400
- 45. How to start?1. Make common decision2. Start slowly3. Select only the most problematic modules4. Inspect and adapt
- 46. 8tipsand tricks
- 47. Before or after check-in?
- 48. Track reviewersNot for blame
- 49. Easy to find person who also knows the code
- 50. More responsibility for reviewerChecklist β make your live easierHas error handling code been tested?Are objects accessed by multiple threads thread-safe?Are variables initialized before they are used?
- 51. Comfortable conditions for reviewers
- 52. All rules should be on WIKI
- 53. Use pen and paper
- 54. Use static code analysis
- 56. And what β¦
- 57. Books
Editor's Notes
- #22: Π‘ΠΏΠ΅ΡΠΎΡΡΡΠ΄
- #27: Π’Π°ΠΊ, ΡΡΠΎ-ΡΠΎ Ρ Π½Π΅ ΠΏΠΎΠ½ΠΈΠΌΠ°Ρ, ΡΡΠΎ ΡΡ ΠΏΡΠΎΠ²Π΅ΡΡΠ΅ΡΡ ΡΡΠΈΠΌ ΡΠ΅ΡΡΠΎΠΌ.
- #33: Π‘ΡΡΠΎΡΠΊΠΈ Π΄ΠΎΠΊΠ°, ΠΊΠΎΠ»ΠΈΡΠ΅ΡΡΠ²ΠΎ Π½Π°ΠΉΡΠ΄Π΅Π½Π½ΡΡ ΠΎΡΠΈΠ±ΠΎΠΊ, ....
- #39: Aleksey: before in most cases because of trunk should contain only good code.
- #47: ΠΡΠ»ΠΈΠΊΠΎΠ΄Π½Π΅ΠΏΡΠΎΡ ΠΎΠ΄ΠΈΡΡΠ΅Π²ΡΡΠ²ΡΠΎΡΠΎΠΉΡΠ°Π·, ΡΠΎΠΎΠ½ΡΡΠΈΡΠ°Π΅ΡΡΡΠΎΠΏΠ°ΡΠ½ΡΠΌ ΠΈ ΡΠ΅Π²ΡΡΠ²ΠΈΡΡΡΠ΅ΡΠ΅ΠΊΠ΅ΠΌ-ΡΠΎΠΡΠ»ΠΈΠ·Π°ΠΌΠ΅ΡΠ°Π½ΠΈΡΠΏΡΠΎΡΡΡΠ΅, ΡΠΎΠΎΠ½ΠΈΠΈΡΠΏΡΠ°Π²Π»ΡΡΡΡΡ Π² ΠΏΠ°ΡΠ΅ΡΡΠ°Π·ΡΠΏΡΠΈΡΠ΅Π²ΡΡΠΡΠ»ΠΈΠ·Π°ΠΌΠ΅ΡΠ°Π½ΠΈΠΉΠΎΡΠ΅Π½ΡΠΌΠ½ΠΎΠ³ΠΎ, ΡΠΎΠΎΠ½ΠΈΡΠ°Π·Π±ΠΈΠ²Π°ΡΡΡΡΠ½Π°ΠΏΠΎΠ»Π½ΠΎΡΠ΅Π½Π½ΡΠ΅Π·Π°Π΄Π°ΡΠΈΡΡΠΎΠ±ΡΠ½Π΅Π·Π°ΡΡΠ³ΠΈΠ²Π°ΡΡΠΡΠ»ΠΈΠΊΠΎΠ΄Π½Π΅ΠΏΡΠΎΡΠ΅Π»ΡΠ΅Π²ΡΡΠ²ΠΎΠ²ΡΠΎΡΠΎΠΉΡΠ°Π· ΠΈ Π΅ΡΡΡΡΠ΅ΡΡΠ΅Π·Π½ΡΠ΅Π·Π°ΠΌΠ΅ΡΠ°Π½ΠΈΡ, ΡΠΎΠΎΠ½ΠΎΠ±ΡΠ·Π°ΡΠ΅Π»ΡΠ½ΠΎΠ΄Π΅Π»Π°Π΅ΡΡΡ Π² ΠΏΠ°ΡΠ΅Π Π΅Π²ΡΡΡΡΠΈΡΠ°Π΅ΡΡΡΠΌΠ°ΠΊΡΠΈΠΌΠ°Π»ΡΠ½ΡΠΌΠΏΡΠΈΠΎΡΠΈΡΠ΅ΡΠΎΠΌ, Π½ΠΎΠ½Π΅ΠΏΡΠ΅ΡΡΠ²Π°Π΅ΡΡΠ΅ΠΊΡΡΠ΅ΠΉΠ·Π°Π΄Π°ΡΠΈ (ΠΆΠ΄Π΅ΠΌΠΏΠ΅ΡΠ΅ΡΡΠ²Π°)ΠΠ°Π΄Π°ΡΠ°Π½Π΅ΠΌΠΎΠΆΠ΅ΡΠΏΡΠΎΠ²ΠΈΡΠ΅ΡΡΠ½Π°ΡΠ΅Π²ΡΡΠ΄ΠΎΠ»ΡΡΠ΅ΡΠ΅ΠΌΠ΄ΠΎΡΠ»Π΅Π΄ΡΡΡΠ΅Π³ΠΎΠ΄ΡΠΉΠ»ΠΈΡΠΊΡΠ°ΠΌΠ°Β