Doing Drupal security right
5 likes1,645 views
Gábor Hojtsy gave a presentation on doing Drupal security right. He discussed common web application security risks like SQL injection, cross-site scripting, and insecure direct object references. He explained how Drupal addresses these issues through features like input filtering, form tokens, and access control. Hojtsy emphasized that while Drupal provides secure APIs, developers must use them properly. He also discussed Drupal's open security team that works to find and fix vulnerabilities in Drupal core and contributed modules.
![index.php?id=12
mysql_query(“UPDATE mytable
SET value = ‘”. $value .”’
WHERE id = ”. $_GET[‘id’]);](https://image.slidesharecdn.com/drupalsecurity2011stockholm-110509042412-phpapp02/85/Doing-Drupal-security-right-14-320.jpg)
![index.php?id=12
print $_GET[‘id’];
$output .= $node->title;
Giving full HTML access.](https://image.slidesharecdn.com/drupalsecurity2011stockholm-110509042412-phpapp02/85/Doing-Drupal-security-right-17-320.jpg)
![jQuery.get('/user/1/edit',
function (data, status) {
if (status == 'success') {
var p = /id="edit-user-edit-form-token"
value="([a-z0-9]*)"/;
var matches = data.match(p);
var token = matches[1];
var payload = {
"form_id": 'user_edit',
"form_token": token,
"pass[pass1]": 'hacked',
"pass[pass2]": 'hacked'
};
jQuery.post('/user/1/edit', payload);
}
}
);
Example from Heine Deelstra, Drupal Security team lead
http://heine.familiedeelstra.com/change-password-xss](https://image.slidesharecdn.com/drupalsecurity2011stockholm-110509042412-phpapp02/85/Doing-Drupal-security-right-19-320.jpg)
![index.php?id=12
db_query(“SELECT * FROM {node}
WHERE nid = :id”, array(‘:id’
=> $_GET[‘id’]));](https://image.slidesharecdn.com/drupalsecurity2011stockholm-110509042412-phpapp02/85/Doing-Drupal-security-right-27-320.jpg)
Doing Drupal security right
- 1. Doing Drupal security right Gábor Hojtsy , Acquia May 7th 2011., Drupalcamp Stockholm With special thanks to Four Kitchens, Greg Knaddison and Jakub Suchy
- 2. Why I’m here? • Maintainer for Drupal 6 • De-facto member of the security team
- 3. Why are you here? • Managers? • Site builders? • Themers? • Developers?
- 6. With relatively simple holes, your administrator user can be taken over.
- 7. Open Web Application Security Project’s Top 10 risks http://owasptop10.googlecode.com/files/OWASP Top 10 - 2010.pdf
- 9. Heard of the wordpress.com attack?
- 10. Secure server • Avoid using FTP at all cost (Total Commander is an enemy) • Who do you share your server with? Are you confident? Run other apps? • Keep your OS, PHP, SQL server, etc. up to date
- 11. Secure Drupal • Is your admin password “admin”? • Look at all “administer *” permissions • “administer filters” can take over a site • Use update.module, watch the security news (Wednesdays)
- 12. Secure Drupal • Avoid any kind of PHP input, write your own modules instead • Look into using paranoia.module • Watch your input formats (you can be googled)
- 13. Injection
- 14. index.php?id=12 mysql_query(“UPDATE mytable SET value = ‘”. $value .”’ WHERE id = ”. $_GET[‘id’]);
- 15. Drupal approach • db_query(“UPDATE {mytable} SET value = :value WHERE id = :id”, array (‘:value’ => $value, ‘:id’ => $id); • If you need to include dynamic table or column names in your query, see db_escape_table()
- 16. Cross Site Scripting (XSS)
- 17. index.php?id=12 print $_GET[‘id’]; $output .= $node->title; Giving full HTML access.
- 18. 64% likeliness a website has Cross site scripting issues https://www.whitehatsec.com/assets/presentations/11PPT/PPT_topwebvulns_030311.pdf
- 19. jQuery.get('/user/1/edit', function (data, status) { if (status == 'success') { var p = /id="edit-user-edit-form-token" value="([a-z0-9]*)"/; var matches = data.match(p); var token = matches[1]; var payload = { "form_id": 'user_edit', "form_token": token, "pass[pass1]": 'hacked', "pass[pass2]": 'hacked' }; jQuery.post('/user/1/edit', payload); } } ); Example from Heine Deelstra, Drupal Security team lead http://heine.familiedeelstra.com/change-password-xss
- 20. Drupal approach • check_plain() to escape text to HTML • check_markup() to format text to HTML • filter_xss() to filter text to HTML • filter_xss_admin() to filter admin text to HTML • node_view($node) instead of $node->body
- 21. Drupal approach • t(), format_plural() placeholders: %name, @url, !insecure t(‘%name has a blog at <a href=”@url”>@url</a>’, array(‘@url’ => valid_url($user->profile_blog), ‘%name’ => $user->name)); • Use Drupal.t(), Drupal.formatPlural() in JS.
- 22. Always consider the type of output needed
- 24. • Weak password storage and account management • Session hijacking / fixation • Lack of session timeout / logout
- 25. Drupal approach • Passwords are stored encrypted • Session IDs changed when permissions change • Drupal works with Apache’s SSL transport • Modules to set certain URLs to use SSL
- 26. Insecure direct object references
- 27. index.php?id=12 db_query(“SELECT * FROM {node} WHERE nid = :id”, array(‘:id’ => $_GET[‘id’]));
- 28. Drupal approach • Menu system handles permission checking • user_access(‘administer nodes’, $account) • node_access(‘edit’, $node, $account); • $select->addtag(‘node_access’); • Form API checks for data validity
- 29. Cross Site Request Forgery (CSRF)
- 32. Drupal approach • Form API works with POST submissions by default (makes it harder) • Form API includes form tokens, requires form retrieval before submission, checks valid values • drupal_valid_token() provided to generate/validate tokens for GET requests
- 33. Insecure cryptographic storage
- 34. Drupal approach • Drupal stores user passwords encrypted with a one-way hash • Different randomly generated private key is provided on each site, which can be used to do reversible encryption • Up to you to ensure backups are properly protected
- 35. Failure to restrict URL access
- 36. Drupal approach • Menu system uses access callback and access arguments • Continually review permissions
- 38. Drupal approach • Run Drupal on top of full SSL • Use securepages and securepages_prevent_hijack to wall your important pages • http://crackingdrupal.com/blog/ greggles/drupal-and-ssl-multiple- recipes-possible-solutions • Use a valid certificate
- 41. Drupal approach • Drupal has various internal redirections, which use local paths and generate URLs based on them • Look for use of drupal_goto() and Form API #redirect instances in your modules to validate their compliance
- 42. Is Open Source secure?
- 43. “Open Source is secure” • Open Source makes people look at it • Popularity gets more eyes • There are always more smart people to find and fix problems
- 44. “Open Source is insecure” • People can equally find holes • Some people (inadvertently) disclose issues in the public • Fix becomes public and can / will be reviewed
- 46. Developers and users • Drupal APIs are designed to be secure • It is eventually up to programmers to use them that way • http://drupal.org/writing-secure-code • Tools designed for security can still be misconfigured
- 47. Drupal security team A team of volunteers working to ensure best security of Drupal and thousands of contributed modules
- 49. What’s supported? • Drupal core and all(!) contributed projects on drupal.org • Not actively looking for vulnerabilities in contributed modules • Stable releases (development versions only for very popular modules) • Only current and one earlier versions are supported: now 7.x and 6.x
- 50. Points of contact • Releases at http://drupal.org/security • Reporting issues: http://drupal.org/ node/101494 • Reporting cracked sites: http:// drupal.org/node/213320
- 52. These slides are (CC) Images used: http://www.flickr.com/photos/rtv/2398561954/ http://www.flickr.com/photos/jonk/19422564/ http://www.flickr.com/photos/duncan/2693141693/ http://www.flickr.com/photos/duncan/2742371814 http://www.flickr.com/photos/jontintinjordan/3736095793/ http://www.flickr.com/photos/djbrady/2304740173/ http://www.flickr.com/photos/inkytwist/2654071573/ http://www.flickr.com/photos/duncan/2741594585/ http://www.flickr.com/photos/shellysblogger/2924699161/ http://www.flickr.com/photos/blogumentary/434097609/ http://www.flickr.com/photos/glamhag/2214986176/ http://www.flickr.com/photos/duncan/2693140217/ This presentation created by Gábor Hojtsy Licensed: http://creativecommons.org/licenses/by-nc-sa/2.0/
- 53. Questions?
- 54. Thank you! Gábor Hojtsy, Acquia @gaborhojtsy